Skip to content

Try to fix carousel issues #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amakarudze merged 2 commits into from
Dec 21, 2025
Merged

Try to fix carousel issues #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92341ca
Try to fix carousel issues
amakarudze Dec 21, 2025
aa02b87
Fix carousel slider
amakarudze Dec 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions e2e/carousel.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,20 @@
import { test, expect } from '@playwright/test';

test('carousel container exists on /en/', async ({ page }) => {
test('carousel initializes on /en/', async ({ page }) => {
await page.goto('/en/');
await page.waitForSelector('.swiper, .carousel'); // adjust to your actual class
await expect(page.locator('.swiper, .carousel')).toBeVisible();
});

const container = page.locator('swiper-container');
await expect(container).toBeVisible();

await page.waitForFunction(() => {
const el = document.querySelector('swiper-container');
return el && el.swiper;
});

const hasSwiper = await page.evaluate(() => {
const el = document.querySelector('swiper-container');
return !!el.swiper;
});

expect(hasSwiper).toBe(true);
});
19 changes: 0 additions & 19 deletions src/components/Carousel.astro
View file
Open in desktop

This file was deleted.

17 changes: 17 additions & 0 deletions src/components/Carousel.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { useEffect } from "react";
import { register } from "swiper/element/bundle";
import "swiper/swiper-bundle.css";

export default function Carousel() {
useEffect(() => {
register();
}, []);

return (
<swiper-container slides-per-view="1" autoplay="true" loop="true">
<swiper-slide>Item 1</swiper-slide>
<swiper-slide>Item 2</swiper-slide>
<swiper-slide>Item 3</swiper-slide>
</swiper-container>
);
}
4 changes: 1 addition & 3 deletions src/components/Sidebar.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
---
const { currentOS } = Astro.props;
import 'swiper/css';
import 'swiper/element/bundle';
import Carousel from '../components/Carousel.astro';
import Carousel from '../components/Carousel.jsx';
---

<nav>
Expand Down
5 changes: 0 additions & 5 deletions src/layouts/TutorialLayout.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,10 @@ const { title, currentOS } = Astro.props;
<meta charset="utf-8" />
<title>{title} | Django Girls Tutorial</title>
<link rel="stylesheet" href="/styles.css" />
<script type="module" src="/src/scripts/swiper.js"></script>
<script type="module" src="/src/scripts/sidebar-toggle.js"></script>
</head>
<body>
<header>
<h1>Django Girls Tutorial</h1>
<button class="menu-toggle" aria-controls="sidebar" aria-expanded="false">
☰ Menu
</button>
</header>

<div class="overlay"></div>
Expand Down
1 change: 1 addition & 0 deletions src/scripts/swiper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { register } from 'swiper/element/bundle';
import 'swiper/swiper-bundle.css';

register();