Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure user settings from the environment #329

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Configure user settings from the environment #329

wants to merge 2 commits into from

Conversation

ryneeverett
Copy link
Contributor

@ryneeverett ryneeverett commented Aug 2, 2024 •
edited
Loading

The motivation here is to remove the steps of the build process which involve editing in-tree files (init.sh and Generate_Signing_Keys.sh), which complicates updates.

@ryneeverett
Build description from settings.
39a9117 
This eliminates a manual step in the build process.
@ryneeverett
Set user configurable options from environment
f9f6560 
This allows setting environment variables rather than editing init.sh
and sets default values when the variables aren't found in the
environment.
@SkewedZeppelin
Copy link
Member

Overrides can already be provided via a drop-in

DivestOS-Build/Scripts/init.sh

Line 106 in 2bb4d94

[ -f "$HOME/.divested.vars" ] && source $HOME/.divested.vars && echo "included $HOME/.divested.vars config"

@ryneeverett
Copy link
Contributor Author

ryneeverett commented Aug 2, 2024 •
edited
Loading

I hadn't noticed that so I'll have to give that a try, thanks! I dropped the commit changing all the settings so now I'm only asking to add the settings to avoid editing Generate_Signing_Keys.sh.

@ryneeverett ryneeverett changed the title Configure user settings from the environment Set description from user settings Aug 2, 2024
@ryneeverett ryneeverett changed the title Set description from user settings Configure user settings from the environment Aug 6, 2024
@ryneeverett
Copy link
Contributor Author

Overrides can already be provided via a drop-in

The problem with this approach is that it is no good for DOS_WORKSPACE_ROOT because DOS_SIGNING_KEYS and DOS_SIGNING_GPG build upon it so they will still point to /mnt/dos/Signing_Keys/*. Sure, one could override those too but it doesn't seem very future-proof. Any additional interdependency of settings will cause unexpected behavior with this approach to user settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryneeverett @SkewedZeppelin