Event toggle function pause new #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utedCollective/Sovryn-smart-contracts into event-toggleFunctionPause-new
ororopickpocket
requested changes
Nov 3, 2021
| assembly { | ||
| paused := sload(slot) | ||
| } | ||
| require(paused != isPaused, "invalid"); |
There was a problem hiding this comment.
the require is not strictly required here, but doesn't hurt either. however, the error message doesn't provide any valuable information. change it to "isPaused is already set to that value" or similar message.
| assembly { | ||
| sstore(slot, isPaused) | ||
| } | ||
| emit ToggleFunctionPaused(funcId, !isPaused, isPaused); |
There was a problem hiding this comment.
the event should rather be called
ToggledFunctionPause
(toggle is the verb here)
smbsp
changed the base branch from
refactor-loantoken-logic
to
rubicon-deployment
ororopickpocket
approved these changes
Nov 24, 2021
tjcloa
approved these changes
Nov 24, 2021
…llective/Sovryn-smart-contracts into event-toggleFunctionPause-new
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #297
Added an event ToggleFunctionPaused to the function toggleFunctionPause()
We earlier had Contract Size issues and hence this version is built using updated Loan Token logic using Beacon Chain. This PR is a replacement of: #317