dont use DecodeMulti #72
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I noticed that when
logToTerminal
is true,EOF
errors are printed due to line 578. For example, withgo test -v
, output includesPrinting each field of
e
when this occurs, the output shows thate.Pid
is not set. This is due todec.DecodeMulti
being called after theVClockPayload
has already been decoded. This leaves no data for the subsequent decode intod.Pid
, hence theEOF
.If desired, I can also add/modify a test like this in
govec_test.go
: