Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flags): implement new member flags #1246

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Snipy7374
Copy link
Collaborator

Summary

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Snipy7374 Snipy7374 added t: api support Support of Discord API features s: needs review Issue/PR is awaiting reviews t: enhancement New feature labels Nov 22, 2024
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some tiny adjustments - the new attributes should also all have a .. versionadded::.
Other than that, lgtm!

disnake/flags.py Outdated Show resolved Hide resolved
@@ -0,0 +1 @@
Implement :attr:`.MemberFlags.is_guest`, :attr:`.MemberFlags.started_home_actions`, :attr:`.MemberFlags.completed_home_actions`, :attr:`.MemberFlags.automod_quarantined_username`, :attr:`.MemberFlags.dm_settings_upsell_acknowledged` new member flags.
Copy link
Member

@shiftinv shiftinv Nov 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Implement :attr:`.MemberFlags.is_guest`, :attr:`.MemberFlags.started_home_actions`, :attr:`.MemberFlags.completed_home_actions`, :attr:`.MemberFlags.automod_quarantined_username`, :attr:`.MemberFlags.dm_settings_upsell_acknowledged` new member flags.
Implement :attr:`~MemberFlags.is_guest`, :attr:`~MemberFlags.started_home_actions`, :attr:`~MemberFlags.completed_home_actions`, :attr:`~MemberFlags.automod_quarantined_username`, :attr:`~MemberFlags.dm_settings_upsell_acknowledged` new member flags.

Co-authored-by: shiftinv <[email protected]>
Signed-off-by: Snipy7374 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: needs review Issue/PR is awaiting reviews t: api support Support of Discord API features t: enhancement New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement new member flags
2 participants