Repository navigation
Fix pagination on empty timeline - #2523
Open
ivan-magda wants to merge 1 commit into
Open
ivan-magda wants to merge 1 commit into
ivan-magda wants to merge 1 commit into
Conversation
ivan-magda
changed the title
ivan-magda
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2522.
An empty timeline was still marked as having a next page, so the footer tried to load one without a status ID and showed Retry.
The next-page footer now only appears when the data source contains at least one status. The check uses the unfiltered data, so pagination still works when content filters hide the loaded posts. It also handles deleting the last status. Gap loading and request error handling stay the same.
The empty Home timeline still has no placeholder. We could use
PlaceholderViewto show "No posts yet", possibly with a "Find people to follow" action in a follow-up.