Firefly PC v5.2.0 #11610
Draft
Firefly PC v5.2.0 #11610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add chain configs * feat: add chain icons
* chore: bump version to 2.26.2
* refactor: config
* refactor: default constants is {}
* feat: get params `count` to poap event api * feat: add pageable total
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -10,7 +10,7 @@ | |||
|
|
|||
| export function getCommunityLink(links: string[]): TrendingAPI.CommunityUrls { | |||
| return links.map((x) => { | |||
| if (x.includes('twitter')) return { type: 'twitter', link: x } | |||
| if (x.includes('twitter') || x.includes('x.com')) return { type: 'twitter', link: x } | |||
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
There was a problem hiding this comment.
@guanbinrui @swkatmask you must use this
import { isDomainOrSubdomainOf } from '@masknet/shared-base'
if (isDomainOrSubdomainOf(x, 'x.com')) return { type: 'twitter', link: x }otherwise, v2ex.com also passes this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add
getOwnersByContractapifeat: adjust
getOwnersByContractparamscursorDescription
Closes MF-0000
Type of change
Previews
Checklist
console.logsIf this PR depends on external APIs:
chrome-extension://[id]moz-extension://[id]