-
Notifications
You must be signed in to change notification settings - Fork 127
Rust Bindings for Macenko PCA #1184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
barrettMCW
wants to merge
24
commits into
DigitalSlideArchive:master
Choose a base branch
from
barrettMCW:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@manthey Finally passing all the circleci stuff! If everything looks good as is, I can replace the old python versions with the rust version and double check that things still pass. |
Author
|
@manthey Hey! Just checking in. Is there anything I can do to help? |
Contributor
|
Sorry for my delay here -- I've been distracted with other projects and vacation. I'll dig into this this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #1181
Hey y'all! I should have something that builds and adds a histomicstk._rust module with all the bindings. As it stands, I have them separate for testing purposes, just appended _rs to the original function name. Assuming all looks good to everyone I can replace the python versions with the rust bindings.
Do we want to add more bindings from rust? Like utils or _linalg? (get_principal_components probably performs about the same, but magnitude and normalize might be faster)
Noticed some things too. There's slight discrepancies between the matrices still, I'm not sure what it is. It's all identical up to f32, but beyond that precision it gets a little off. Also realized my benchmarks were slightly biased, still a major improvement.
Here's a non-biased result on masked 4µ: