-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update boundary detection in FSD feature extraction #1143
base: master
Are you sure you want to change the base?
Conversation
@FattanePourakpour please address the complex curvature problem also mentioned in Issue #1139 and then let's look at getting the tests to pass. Most tests compare to stored values so we would need to generate new values since the new algorithm is fundamentally changed. |
@FattanePourakpour I see you have some commits why say "black". The codebase predates the existence of black and uses flake8 and autopep8. |
@manthey thank you for the clarification. I will do |
@FattanePourakpour The CI is failing because the test_compute_fsd_features no longer matches the stored ground truth file. We can update the ground truth to match the new values if they are what we expect. |
@manthey Yes, since the new algorithm has fundamentally changed, the ground truth needs to be updated to match the new values for the tests to pass. |
Fix an issue where the fsd feature boundaries could vary because of a failure to check or guard bounds.
@FattanePourakpour I merged master and updated ground truth values. One thing that took me a while was that the If you are content with my changes and have the authority to do so, go ahead and merge. |
@manthey thank you. We will look at this to see how we can update testing in the future. This is a fundamental change in the feature extraction so we need to note that the values will be very different in the release (different but correct and likely better). |
np.argwhere
does not trace boundaries accurately; instead,trace_object_boundaries
is used.