-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/setting up ruff #5
base: main
Are you sure you want to change the base?
Feature/setting up ruff #5
Conversation
try: | ||
tree = etree.parse(input_svg_file, parser) | ||
except etree.XMLSyntaxError as e: | ||
print(f"Error parsing SVG: {e}") | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this try except because it can make it harder to debug this code
print(f"Error: {input_svg_file} does not exist.") | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replaced this with a raise FileNotFoundError
Hey sorry for the delay in responding, I've been super busy. Will go through this more thoroughly when I have a chance. It's a bit of a pain to prepare everything again and resubmit to pip and also test everything, so not sure these changes are significant enough to justify doing that just yet. But appreciate the interest in the project and will try to integrate everything when I have more time. |
First i want to say that this code is cool.
Im planing to use it and want to make it easier to maintain.
this consist of 2 major changes
1 adding ruff for linting and formatting
2 moving the demo code to its own file
there are 2 code changes that i will call out with comments