Feature/setting up ruff#5
Closed
RichieCahill wants to merge 6 commits intoDicklesworthstone:mainfrom
RichieCahill:feature/setting-up-ruff
Closed
Feature/setting up ruff#5RichieCahill wants to merge 6 commits intoDicklesworthstone:mainfrom RichieCahill:feature/setting-up-ruff
RichieCahill wants to merge 6 commits intoDicklesworthstone:mainfrom
RichieCahill:feature/setting-up-ruff
Conversation
RichieCahill
commented
Mar 2, 2024
Comment on lines
-71
to
-75
| try: | ||
| tree = etree.parse(input_svg_file, parser) | ||
| except etree.XMLSyntaxError as e: | ||
| print(f"Error parsing SVG: {e}") | ||
| return |
Author
There was a problem hiding this comment.
I removed this try except because it can make it harder to debug this code
Comment on lines
-67
to
-68
| print(f"Error: {input_svg_file} does not exist.") | ||
| return |
Author
There was a problem hiding this comment.
I replaced this with a raise FileNotFoundError
Owner
|
Hey sorry for the delay in responding, I've been super busy. Will go through this more thoroughly when I have a chance. It's a bit of a pain to prepare everything again and resubmit to pip and also test everything, so not sure these changes are significant enough to justify doing that just yet. But appreciate the interest in the project and will try to integrate everything when I have more time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First i want to say that this code is cool.
Im planing to use it and want to make it easier to maintain.
this consist of 2 major changes
1 adding ruff for linting and formatting
2 moving the demo code to its own file
there are 2 code changes that i will call out with comments