using pkgx is easier than dependency management with pip / virtualenv #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I use ruff as a linter, and it included a bunch of linting changes as well. |
|
Cool, thanks! Will check it out. This is the first PR for this project that
seems worth approving.
…On Sat, Feb 1, 2025 at 2:36 PM Sanchit Ram Arvind ***@***.***> wrote:
- pkgx.sh manages the dependencies like poppler and tesseract, needed
to run the code
- pkgx defers to uv to load all the python requirements
- the shebang on top of llm_aided_ocr.py means you can just call the
file directly
I also tweaked it so that you can pass the arg to the file directly, as
opposed to changing the input_pdf_file_path each time. so usage would be:
./llm_aided_ocr.py <FILE_PATH>
readme reflects all of these changes. pretty cool project!
------------------------------
You can view, comment on, or merge this pull request online at:
#22
Commit Summary
- 606fc4a
<606fc4a>
add example env vars
- e19ca72
<e19ca72>
lint
- b58f5a2
<b58f5a2>
shebang
- 65f4438
<65f4438>
pdf arg to llm_aided_ocr.py
- 43640ae
<43640ae>
pkgx.yaml for pkgx dependencies
- c9e7b29
<c9e7b29>
readme
File Changes
(4 files
<https://github.com/Dicklesworthstone/llm_aided_ocr/pull/22/files>)
- *A* .env.example
<https://github.com/Dicklesworthstone/llm_aided_ocr/pull/22/files#diff-a3046da0d15a27e89f2afe639b25748a7ad4d9290af3e7b1b6c1a5533c8f0a8c>
(4)
- *M* README.md
<https://github.com/Dicklesworthstone/llm_aided_ocr/pull/22/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5>
(60)
- *M* llm_aided_ocr.py
<https://github.com/Dicklesworthstone/llm_aided_ocr/pull/22/files#diff-f7e2caee9544f1882cdc003b5f2f1ab0f0b0078138538e88a83144f64df0e191>
(484)
- *A* pkgx.yaml
<https://github.com/Dicklesworthstone/llm_aided_ocr/pull/22/files#diff-997b9ef87d19d97c7521fa85c0b717f40dd5ad3e71785f8faffbeeaa3bcc37ea>
(4)
Patch Links:
- https://github.com/Dicklesworthstone/llm_aided_ocr/pull/22.patch
- https://github.com/Dicklesworthstone/llm_aided_ocr/pull/22.diff
—
Reply to this email directly, view it on GitHub
<#22>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AILNF3QQWGLS3TCP3WJ6AC32NUO3DAVCNFSM6AAAAABWJSXHVCVHI2DSMVQWIX3LMV43ASLTON2WKOZSHAZDKMZYHEYDMOI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
not improving the process itself, but just the distribution / ease of use. I wanted to add my fork to pkgx's scripting library as well, making it easier for other people to find / implement it fwiw, I found this repo via your blogpost: The Short Case for NVIDIA…a lot of it went over my head, but wanted to get more into understanding the architecture side of things |
|
also note that the pkgx version uses python 3.11, not 3.12. this is because of the deprecated |
|
Oh, in that case I think I won’t merge. You should fork it though and just
have another version that has this functionality.
…On Sat, Feb 1, 2025 at 3:04 PM Sanchit Ram Arvind ***@***.***> wrote:
also note that the pkgx version uses python 3.11, not 3.12. this is
because of the deprecated ImpImporter in the pkgutil library in 3.12. I'm
trying to figure out which requirement is specifically causing this…also
known is dependency hell. for now, using 3.11 seems to do the job.
See also:
https://stackoverflow.com/questions/77364550/attributeerror-module-pkgutil-has-no-attribute-impimporter-did-you-mean
—
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AILNF3S3VDKNHWFHQFFNR5L2NUSEJAVCNFSM6AAAAABWJSXHVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRZGA4TEMRXGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Sounds good. Feel free to incorporate the pkgx if you want. I'll make it available there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uvto load all the python requirementsllm_aided_ocr.pymeans you can just call the file directlyI also tweaked it so that you can pass the arg to the file directly, as opposed to changing the
input_pdf_file_patheach time. so usage would be:readme reflects all of these changes. pretty cool project!