Delete And Drop Statements #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hassanelshazly
commented
May 17, 2022
There was a problem hiding this comment.
@abdomustafafouaad Great job ya Abdo 🎉
Please add compile/ and .cache/ to .gitignore
and execute git rm --cached compile/ .cache/
Comment on lines
+140
to
+154
| if (nftw((m_base_path + "/" + table_name).c_str(), | ||
| //its an anonymous function and i dont know how to style it in our style | ||
| [](const char *pathname, const struct stat *sbuf, int type, struct FTW *ftwb) { | ||
| if(remove(pathname) < 0) | ||
| { | ||
| util::Logger::make().err("Error writing Metadata: %d", errno); | ||
| return -1; | ||
| } | ||
| return 0; | ||
| } , | ||
| 10, | ||
| FTW_DEPTH|FTW_MOUNT|FTW_PHYS) < 0) | ||
| { | ||
| util::Logger::make().err("Error writing Metadata: %d", errno); | ||
| } |
There was a problem hiding this comment.
How about this styling
auto remove_fn = [](const char *pathname, const struct stat *sbuf, int type, struct FTW *ftwb) {
if(remove(pathname) < 0) {
util::Logger::make().err("Error couldn't remove %s: %d", pathname, errno);
return -1;
}
return 0;
};
if (nftw((m_base_path + "/" + table_name).c_str(), remove_fn, 10,
FTW_DEPTH|FTW_MOUNT|FTW_PHYS) < 0) {
util::Logger::make().err("Error couldn't delete table : %d", table_name.c_str(), errno);
}
| dynamic_cast<lang::DropTableStatement *>(statement); | ||
| dorp_table_statement != nullptr) { | ||
| auto result = dorp_table_statement->execute(db); | ||
| std::cout << dorp_table_statement->m_table << std::endl; |
There was a problem hiding this comment.
you can remove this now and change data members to private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.