Skip to content

Conversation

@Relm-Arrowny
Copy link
Contributor

Fixes #ISSUE

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Relm-Arrowny and others added 30 commits October 27, 2025 12:10
…dLightSource/dodal into create_apple2_energy_motor_lookUP
Change 'nc' parameter to negative ROW_PHASE_CIRCULAR and adjust phase calculation based on pol.
Removed outdated docstring from Lookuptable class and updated initialization docstring for I10EnergyMotorLookup class.
@Relm-Arrowny Relm-Arrowny linked an issue Nov 21, 2025 that may be closed by this pull request
12 tasks
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 89.85507% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.03%. Comparing base (62c1000) to head (18f2bdf).
⚠️ Report is 24 commits behind head on 1663-i09-energy.

Files with missing lines Patch % Lines
src/dodal/devices/i21/i21_apple2.py 36.36% 7 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           1663-i09-energy    #1727      +/-   ##
===================================================
- Coverage            99.09%   99.03%   -0.07%     
===================================================
  Files                  276      277       +1     
  Lines                10218    10252      +34     
===================================================
+ Hits                 10126    10153      +27     
- Misses                  92       99       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Relm-Arrowny Relm-Arrowny changed the base branch from main to 1663-i09-energy November 21, 2025 16:28
Base automatically changed from 1663-i09-energy to main November 25, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i21-energy-devices

3 participants