-
Notifications
You must be signed in to change notification settings - Fork 12
1725 i21 energy devices #1727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Relm-Arrowny
wants to merge
119
commits into
main
Choose a base branch
from
1725-i21-energy-devices
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
1725 i21 energy devices #1727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dLightSource/dodal into create_apple2_energy_motor_lookUP
…P' into 1663-i09-energy
Change 'nc' parameter to negative ROW_PHASE_CIRCULAR and adjust phase calculation based on pol.
Removed outdated docstring from Lookuptable class and updated initialization docstring for I10EnergyMotorLookup class.
…'origin' into 1663-i09-energy
Removed the POLY_DEG list from the test file.
12 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 1663-i09-energy #1727 +/- ##
===================================================
- Coverage 99.09% 99.03% -0.07%
===================================================
Files 276 277 +1
Lines 10218 10252 +34
===================================================
+ Hits 10126 10153 +27
- Misses 92 99 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ce/dodal into 1725-i21-energy-devices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}