Skip to content

Conversation

@jacob720
Copy link
Contributor

@jacob720 jacob720 commented Nov 12, 2025

Fixes #1076

Required by DiamondLightSource/mx-bluesky#1436

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.09%. Comparing base (400fe84) to head (c65bc9a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1706   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files         276      276           
  Lines       10147    10153    +6     
=======================================
+ Hits        10055    10061    +6     
  Misses         92       92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacob720 jacob720 force-pushed the use_fastcs_eiger_for_xrc branch from 3e6ebae to f787c36 Compare November 12, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to the ophyd-async Eiger

2 participants