Skip to content

Conversation

@fajinyuan
Copy link
Contributor

Fixes #1526

Instructions to reviewer on how to test:

  1. revert to base main
  2. cannot merge as 'dodal connect i06' does not support shared devices defined in another .py file
  3. I disagree with beamline software has to duplicate shared devices for each branch or end station as past experience told us they were very difficult to keep in sync all changes cross different end stations and branches for a beamline.
  4. current 'standards ' have to be improved to support shared devices without duplication.

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@fajinyuan fajinyuan requested a review from a team as a code owner September 18, 2025 14:40
@fajinyuan fajinyuan linked an issue Sep 19, 2025 that may be closed by this pull request
3 tasks
@oliwenmandiamond
Copy link
Contributor

oliwenmandiamond commented Nov 28, 2025

@fajinyuan I am closing this, this is too out of date to recover and the reverting is no longer needed as I've closed #1532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add PGM device i06

3 participants