-
Notifications
You must be signed in to change notification settings - Fork 12
Revert 1526 add pgm i06 #1554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Revert 1526 add pgm i06 #1554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add PGM support for i06 #116 * add PGM support using i06_shared for i06 and i06-1 * add PGM support for i06 #116 * add PGM support using i06_shared for i06 and i06-1 * configure _BEAMLINE_SHARED to include i06_shared for i06 and i06-1 * fix spell mistake * Update src/dodal/beamlines/i06_shared.py remove name argument as it is the same as default value Co-authored-by: oliwenmandiamond <[email protected]> --------- Co-authored-by: oliwenmandiamond <[email protected]>
3 tasks
Contributor
|
@fajinyuan I am closing this, this is too out of date to recover and the reverting is no longer needed as I've closed #1532 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1526
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}