-
Notifications
You must be signed in to change notification settings - Fork 12
Add DeviceManager as alternative to make_all_devices #1549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ff60344 to
df2a27c
Compare
0c1a7f3 to
a3507d7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1549 +/- ##
==========================================
+ Coverage 99.09% 99.13% +0.03%
==========================================
Files 277 278 +1
Lines 10209 10478 +269
==========================================
+ Hits 10117 10387 +270
+ Misses 92 91 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
11dcde0 to
6e29bb8
Compare
DominicOram
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, minor stuff mostly. However, I think the typing for v1 is broken if I run eiger = i03.fastcs_eiger.build(mock=True) the type system picks up that eiger is an EigerDetector if I run eiger = i03.eiger.build(mock=True) it thinks it's a V1@v1_init. Not that big a deal as we only have the one v1 device.
6e29bb8 to
87ded47
Compare
rtuck99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, you can make the change with the LazyFixtures if you want but I'm not terribly fussed either way
Should be fixed |
f94bf5e to
f626761
Compare
Maybe enough tests to cover basic use
9af2428 to
9ccf338
Compare
I'm happy if Rob is happy
See #1574 for some context