Skip to content

Conversation

@tpoliaw
Copy link
Contributor

@tpoliaw tpoliaw commented Sep 18, 2025

See #1574 for some context

@tpoliaw tpoliaw force-pushed the device_context branch 2 times, most recently from 0c1a7f3 to a3507d7 Compare October 23, 2025 13:25
@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.13%. Comparing base (f50aaaa) to head (81197bd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1549      +/-   ##
==========================================
+ Coverage   99.09%   99.13%   +0.03%     
==========================================
  Files         277      278       +1     
  Lines       10209    10478     +269     
==========================================
+ Hits        10117    10387     +270     
+ Misses         92       91       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tpoliaw tpoliaw force-pushed the device_context branch 4 times, most recently from 11dcde0 to 6e29bb8 Compare November 13, 2025 16:57
@tpoliaw tpoliaw marked this pull request as ready for review November 13, 2025 16:57
@tpoliaw tpoliaw requested a review from a team as a code owner November 13, 2025 16:57
@tpoliaw tpoliaw changed the title Proof of concept device manager Add DeviceManager as alternative to make_all_devices Nov 13, 2025
@rtuck99 rtuck99 self-assigned this Nov 14, 2025
Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, minor stuff mostly. However, I think the typing for v1 is broken if I run eiger = i03.fastcs_eiger.build(mock=True) the type system picks up that eiger is an EigerDetector if I run eiger = i03.eiger.build(mock=True) it thinks it's a V1@v1_init. Not that big a deal as we only have the one v1 device.

Copy link
Contributor

@rtuck99 rtuck99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, you can make the change with the LazyFixtures if you want but I'm not terribly fussed either way

@tpoliaw
Copy link
Contributor Author

tpoliaw commented Nov 21, 2025

However, I think the typing for v1 is broken

Should be fixed

@DominicOram DominicOram dismissed stale reviews from DiamondJoseph and themself November 26, 2025 16:25

I'm happy if Rob is happy

@DominicOram DominicOram merged commit b539ac0 into main Nov 27, 2025
11 checks passed
@DominicOram DominicOram deleted the device_context branch November 27, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants