Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-128: Add plate view to queue container page #900

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-128

Summary:

When queuing samples in a plate for data collection, it would be useful to show a view of the plate, rather than just a list of (possibly 1000s of) samples.
First attempt at this was #839 but had to be reverted.

Changes:

  • Display a plate view on the "Prepare For Data Collection" page (/containers/queue/)
  • Filter the list when you click on a well
  • Load the inspection image when you click on a well
  • Ensure 'Add all to queue' only adds from the current well (otherwise you get an error as the server queues samples the client isn't showing)

To test:

  • Go to a proposal with plates (eg nt37104) and then go to a plate (eg /containers/cid/317254)
  • Check clicking on a well still loads the inspection image for the well (this page hasn't changed)
  • Click "Prepare for Data Collection" near the bottom
  • Check a map of the plate appears, and that wells with samples in are outlined (most of them). Check the container name at the top is a link back to the previous page.
  • Check that clicking on a well shows a list of samples from that well
  • Check the Auto/Manual/Point/Region filters work, alone and in combination with a well
  • Check the "Add Current Page to Queue" button adds only those currently displayed
  • Check the "Add All to Queue" adds all the pages, but obeys the Auto/Manual/Point/Region filters, and if you have clicked on a well, it obeys that filter also.
  • Check the list of "Queued Samples" stays the same even if you change filter on "Available Samples"

@gfrn
Copy link
Collaborator

gfrn commented Feb 17, 2025

When you click a well whilst preparing it for a data collection (say, /containers/queue/317254), all other wells turn grey. Is that by design?

@ndg63276
Copy link
Collaborator Author

When you click a well whilst preparing it for a data collection (say, /containers/queue/317254), all other wells turn grey. Is that by design?

Not by design as such, but a necessary side-effect of connecting the plate diagram and the collection of available samples. By clicking on a well, you reduce the available samples to just those from that well, so the others are hidden.

The downside I noticed was that if you clicked on a well with no samples, nothing was highlighted at all, which could be confusing. So I've added a commit to always highlight the last clicked well in cyan, even if there were no samples in it.

@gfrn
Copy link
Collaborator

gfrn commented Feb 17, 2025

When you click a well whilst preparing it for a data collection (say, /containers/queue/317254), all other wells turn grey. Is that by design?

Not by design as such, but a necessary side-effect of connecting the plate diagram and the collection of available samples. By clicking on a well, you reduce the available samples to just those from that well, so the others are hidden.

The downside I noticed was that if you clicked on a well with no samples, nothing was highlighted at all, which could be confusing. So I've added a commit to always highlight the last clicked well in cyan, even if there were no samples in it.

That makes sense, this makes things clearer too! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants