chore(xtask): allow the rdpeudp and rdpemt title scopes - #1628
Merged
Marc-André Moreau (mamoreau-devolutions) merged 1 commit intoAug 11, 2026
Conversation
The RDP-UDP transport arrives as two crates, `ironrdp-rdpeudp` and `ironrdp-rdpemt`, and neither name is in the canonical scope list, so `cargo xtask pr check-message` rejects the titles of the pull requests that add them. Placed next to `rdpeusb`, which keeps the protocol extension crates together. No scope for the tokio adapter that follows. The list names subsystems rather than crates, which is why there is no `tokio`, `async` or `blocking` entry either, so changes to `ironrdp-rdpeudp-tokio` belong under `rdpeudp`.
Greg Lamberson (glamberson)
temporarily deployed
to
llm-providers
August 11, 2026 00:35 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
github-actions
Bot
added
maintainer-required
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Aug 11, 2026
Marc-André Moreau (mamoreau-devolutions)
merged commit Aug 11, 2026
8934e4a
into
Devolutions:master
39 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore(xtask): allow the rdpeudp and rdpemt title scopes
Two entries in
CANONICAL_SCOPES, following #1615.The RDP-UDP transport Marc-André Moreau (@mamoreau-devolutions) asked for on #140 arrives as two
crates,
ironrdp-rdpeudpandironrdp-rdpemt. Neither name is in the list, socargo xtask pr check-messagerejects the titles of the PRs that add them:#1626 and #1627 are both red on
Check messagefor exactly this, witheverything else green.
Placed next to
rdpeusb, which keeps the protocol extension crates together.No scope for the tokio adapter
The transport also comes with
ironrdp-rdpeudp-tokio, and I have deliberatelynot added a scope for it. The list names subsystems rather than crates, which is
why there is no
tokio,async,blockingor-nativeentry either, sochanges to that crate belong under
rdpeudp. Say the word if you would ratherhave one per crate and I will add it.
Test plan
cargo xtask check fmt/lints/tests/typos/locksAlso checked directly against the titles this unblocks, by feeding each to
cargo xtask pr check-messagewith a synthetic event file: the two filed PRsand the three still to come all validate, as does this PR's own title.