ffi: pin diplomat for RustVec Result/Option (WIP catch-up) - #1621
Draft
irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 1 commit into
Draft
ffi: pin diplomat for RustVec Result/Option (WIP catch-up)#1621irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 1 commit into
irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 1 commit into
Conversation
Point workspace patch + ffi deps at irvingoujAtDevolution/diplomat@ab68f7a4 (rust-diplomat/diplomat#1250). IronRDP is still on 0.7-era Diplomat APIs — this is the pin step only; full 0.16 catch-up is required before CI is green. After #1250 merges, cut a Devolutions diplomat tag and finish migration (pattern: Devolutions/IronVNC#1424). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP pin for rust-diplomat/diplomat#1250 (
Result/OptionofBox<[u8]>-> .NETRustVec).this PR
[patch]+ffideps ->irvingoujAtDevolution/diplomat@ab68f7a4diplomat-toolto 0.16.0 (install from that git rev)not done here
IronRDP is still on diplomat 0.7 (CBenoit fork). Jumping the pin alone will not compile until the full 0.16 catch-up. Pattern once unblocked: IronVNC https://github.com/Devolutions/IronVNC/pull/1424
after #1250 merges
Devolutions diplomat tag, then finish migration + move opaque
VecU8byte returns toBox<[u8]>/RustVecwhere it matters.