Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] overhaul to use SASS, Compass, etc #82

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

durka
Copy link
Contributor

@durka durka commented Nov 2, 2016

I created this PR so that I could make comments (since you can't use the issue tracker on a fork).

sean added 6 commits October 31, 2016 14:49
…s, applied material textures, fixed up css conflicts and funny padding oddities, made a mobile layout, applied google's material typography specs to font
@durka
Copy link
Contributor Author

durka commented Nov 2, 2016

@elevati0n

In terms of functionality, things seem to work but I noticed that the result message after you share is blank. Presumably it's looking for a div with a particular ID that got removed.

As for layout, I really like the look/aesthetic but some layout bugs have been introduced. Here are some screenshots from my testing showing problems on some screen sizes:

  • Desktop
    • footer is too high
    • carousel text is hidden behind sample images
  • Mobile (vertical)
    • same as above
    • can't see all of the header ("Learn more" and the logo)
    • start button is too wide
  • Mobile (horizontal)
    • can't see much of anything (and there is nowhere to scroll)

@elevati0n
Copy link

Thank you I really appreciate the feedback. I had to resolve some other issues this week but I will have lots of time today and this weekend to resolve all these issues.

@elevati0n
Copy link

Hi, I forked this off of master today and made sure it had all the same functionality (and even discovered a bug in the process.)
Please test this out and merge it if possible before the branches diverge again =] ]

@elevati0n
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants