You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request enhances the Discrete Points Aggregation chart demos. The main focus is to add user controls for toggling aggregation and selecting the aggregation method, as well as adding a MAX value bar as a reference to make aggregation changes more visible.
Selecting Sum hides the gray MAX reference bars because the later-drawn colored bars have the same width and overlap group, and every annual sum exceeds its monthly maximum. Make the MAX bars wider than the colored bars so the reference remains visible for comparison. Apply the same change in this demo's Vue/App.vue:85, ReactJs/App.js:26, jQuery/index.js:24, and Angular/app/app.component.ts:40.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Selecting Sum hides the gray MAX references behind same-width colored bars, so the colored bars need to be narrower across all demo variants to keep the references visible and hoverable.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Selecting Sum causes the colored bars to completely cover the gray maximum references, preventing the intended comparison with the highest monthly value.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
In Sum mode, the colored bars obscure the gray MAX reference bars and block their tooltips across all five demo implementations, requiring greater padding on the colored bars.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Selecting Sum hides the gray MAX reference bars because the larger foreground bars share their width and overlap group, so the reference bars need a wider footprint to remain visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the Discrete Points Aggregation chart demos. The main focus is to add user controls for toggling aggregation and selecting the aggregation method, as well as adding a MAX value bar as a reference to make aggregation changes more visible.