Skip to content

update discrete aggregation demo - #35834

Merged
DuckTieCorpMember merged 9 commits into
DevExpress:mainfrom
DuckTieCorpMember:update-aggregation-demo
Nov 4, 2026
Merged

DuckTieCorpMember merged 9 commits into
DevExpress:mainfrom
DuckTieCorpMember:update-aggregation-demo

Conversation

@DuckTieCorpMember

Copy link
Copy Markdown
Contributor

This pull request enhances the Discrete Points Aggregation chart demos. The main focus is to add user controls for toggling aggregation and selecting the aggregation method, as well as adding a MAX value bar as a reference to make aggregation changes more visible.

@DuckTieCorpMember DuckTieCorpMember self-assigned this Oct 21, 2026
Copilot AI balanced review requested due to automatic review settings October 21, 2026 10:24
@DuckTieCorpMember
DuckTieCorpMember requested a review from a team as a code owner October 21, 2026 10:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No blocking defects were identified; the remaining documentation correction is minor.

1 open issue
What changed in this PR

Enhances DevExtreme’s Discrete Points Aggregation demos consistently across Angular, React, Vue, and jQuery.

Changes:

  • Adds aggregation toggling and Average, Maximum, and Minimum selection.
  • Adds overlapping MAX reference bars and more varied sample data.
  • Styles the new options panels.

Paths below are relative to apps/demos/Demos/Charts/DiscretePointsAggregation/.

File Description
Vue/​data.ts Updates values and adds reference-series data.
Vue/​App.vue Adds controls, reference bars, and styling.
ReactJs/​styles.css Styles the options panel.
ReactJs/​data.js Updates values and adds reference-series data.
ReactJs/​App.js Adds controls and reference bars.
React/​styles.css Styles the options panel.
React/​data.ts Updates values and adds reference-series data.
React/​App.tsx Adds typed controls and reference bars.
jQuery/​styles.css Styles the options panel.
jQuery/​index.js Configures controls and reference bars.
jQuery/​index.html Adds control containers.
jQuery/​data.js Updates values and adds reference-series data.
Angular/​app/​app.service.ts Supplies updated data and reference series.
Angular/​app/​app.component.ts Adds control state and series customization.
Angular/​app/​app.component.html Binds aggregation controls.
Angular/​app/​app.component.css Styles the options panel.

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 23, 2026 07:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Selecting Sum obscures the maximum-reference bars across the demos, preventing the intended visual comparison.

2 open issues

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 27, 2026 05:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Selecting Sum hides the MAX reference bars across all demo variants, preventing the intended visual comparison.

1 open issue
1 previously missed issue

In code that hasn't changed since last review

Medium severity Widen MAX reference bars to keep them visible behind Sum bars

apps/​demos/​Demos/​Charts/​DiscretePointsAggregation/​React/​App.tsx:29

Selecting Sum hides the gray MAX reference bars because the later-drawn colored bars have the same width and overlap group, and every annual sum exceeds its monthly maximum. Make the MAX bars wider than the colored bars so the reference remains visible for comparison. Apply the same change in this demo's Vue/App.vue:85, ReactJs/App.js:26, jQuery/index.js:24, and Angular/app/app.component.ts:40.

1 resolved since last review

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 28, 2026 06:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Selecting Sum hides the gray MAX references behind same-width colored bars, so the colored bars need to be narrower across all demo variants to keep the references visible and hoverable.

2 open issues

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 28, 2026 09:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Selecting Sum causes the colored bars to completely cover the gray maximum references, preventing the intended comparison with the highest monthly value.

1 open issue
1 resolved since last review

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 28, 2026 11:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

In Sum mode, the colored bars obscure the gray MAX reference bars and block their tooltips across all five demo implementations, requiring greater padding on the colored bars.

2 open issues

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 28, 2026 11:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Selecting Sum hides the gray MAX reference bars because the larger foreground bars share their width and overlap group, so the reference bars need a wider footprint to remain visible.

1 open issue
1 resolved since last review

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 4, 2026 06:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block approval of the cross-framework aggregation demo updates.

1 open issue

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 4, 2026 11:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The aggregation demo updates have no active review issues requiring resolution.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@DuckTieCorpMember
DuckTieCorpMember added this pull request to the merge queue Nov 4, 2026
Merged via the queue into DevExpress:main with commit e26546e Nov 4, 2026
182 checks passed
@DuckTieCorpMember
DuckTieCorpMember deleted the update-aggregation-demo branch November 4, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants