You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
apps/demos/menuMeta.json is not updated. The Stock entry still has "MvcAdditionalFiles": ["/Models/SampleData/FinancialData.cs"], but after DevExpress/dxvcs#52233 the ASP.NET demo takes its data from StockChartData.cs, so the source viewer will show the wrong file. Please point it to /Models/SampleData/StockChartData.cs (the same way it is done for StochasticData.cs and CustomLegendMarkersSampleData.cs). The Equivalents keywords still list workdaysOnly - consider adding zoomAndPan, scrollBar, visualRange.
description.md is not updated. It still says that you can enable argumentAxis.workdaysOnly, and it does not mention the new zoom/pan, scroll bar and visual range API.
Unrelated files in the diff. The two Scheduler recurrence-form__*_mask.png etalons are the same blobs that are already in main (#35687), so the squash will not change them, but merging main into the feature branch will remove this noise from the diff.
Minor:
The initial visual range (Apr 15 - Apr 29) ends exactly on candle dates, so the first and the last candles are cut in half (visible in the new etalons). Padding the range by half a day on each side would fix it.
Mouse wheel and drag zoom are not limited to 3 days the way the buttons are. argumentAxis.minVisualRangeLength: { day: 3 } would make both behave the same.
Export: the default one is replaced by a dxDropDownButton in the toolbar with the same menu (Print, PNG, PDF, JPEG, GIF, SVG)
Title: the chart title is removed from the chart and added as the first toolbar item (location: 'before', class chart-title)
Toolbar icons: arrowleft and arrowright for panning
Axis labels: format: 'MMM dd' is removed, and customizeText shows the date at midnight and the time otherwise. This removes duplicate "Apr 15" labels when zoomed in
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The Vue chart’s range models become stale after zooming or panning, causing toolbar actions to use an outdated viewport and Reset Zoom to potentially do nothing.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
The Stock demos still offer unsupported GIF exports that fall back to PNG, lack a meaningful accessible label for the export/print control, and omit the chart title from exports and printouts.
When the browser cannot encode GIF, selecting “GIF file” raises W2108 and downloads PNG instead. Remove GIF from the custom menu or filter formats by browser support, as the built-in menu did. Apply the same change in the Stock demo's ReactJs/App.js:29, Vue/App.vue:139, jQuery/index.js:113, and Angular/app/app.component.ts:25.
Give the icon-only export button an accessible name
This icon-only control receives the generic accessible name “dropdownbutton”, so screen-reader users cannot identify its export/print purpose. Provide meaningful button text or label the focusable inner button; the outer hint does not supply that label. Apply the same change in the Stock demo's ReactJs/App.js:150, Vue/App.vue:220, jQuery/index.js:180, and Angular/app/app.component.ts:103.
Moving “Stock Price” into the sibling toolbar removes the heading from exported files and printouts because these methods capture only the chart. Preserve the title during export/printing or include it in the exported markup. The same issue affects the Stock demo's ReactJs/App.js:159, Vue/App.vue:229, jQuery/index.js:189, and Angular/app/app.component.ts:112.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.