PivotGrid: update FieldChooser width/height d.ts - #34618
Open
sjbur wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the PivotGrid fieldChooser nested option typings to accept CSS-like string sizes (in addition to numbers) across the core TypeScript declarations and framework wrappers, keeping the public API surface consistent for PivotGrid consumers.
Changes:
- Broadened
dxPivotGridOptions.fieldChooser.height/widthtypes fromnumbertonumber | stringin the public.d.tssources and the aggregateddx.all.d.ts. - Updated Vue, React, and Angular wrapper typings/prop declarations to match the new
number | stringcontract.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/ts/dx.all.d.ts | Updates aggregated PivotGrid option typings for fieldChooser.height/width to number | string. |
| packages/devextreme/js/ui/pivot_grid.d.ts | Updates the primary PivotGrid public .d.ts for fieldChooser.height/width to number | string. |
| packages/devextreme-vue/src/pivot-grid.ts | Allows Vue wrapper nested fieldChooser height/width props to accept Number or String. |
| packages/devextreme-react/src/pivot-grid.ts | Broadens React wrapper nested fieldChooser prop types to number | string. |
| packages/devextreme-angular/src/ui/pivot-grid/nested/field-chooser.ts | Broadens Angular PivotGrid nested field chooser height/width inputs to number | string. |
| packages/devextreme-angular/src/ui/pivot-grid/index.ts | Updates Angular PivotGrid component fieldChooser input/output typings to include string for height/width. |
| packages/devextreme-angular/src/ui/nested/field-chooser.ts | Broadens shared Angular nested field chooser height/width inputs to number | string. |
aleksei-semikozov
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.