Skip to content

PivotGrid: update FieldChooser width/height d.ts - #34618

Open
sjbur wants to merge 1 commit into
DevExpress:mainfrom
sjbur:issue-2567_26_2
Open

PivotGrid: update FieldChooser width/height d.ts#34618
sjbur wants to merge 1 commit into
DevExpress:mainfrom
sjbur:issue-2567_26_2

Conversation

@sjbur

@sjbur sjbur commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@sjbur sjbur self-assigned this Aug 3, 2026
@sjbur sjbur added the 26_2 label Aug 3, 2026
@github-actions github-actions Bot added the .d.ts label Aug 3, 2026
@sjbur
sjbur marked this pull request as ready for review August 3, 2026 14:18
@sjbur
sjbur requested a review from a team as a code owner August 3, 2026 14:18
Copilot AI review requested due to automatic review settings August 3, 2026 14:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the PivotGrid fieldChooser nested option typings to accept CSS-like string sizes (in addition to numbers) across the core TypeScript declarations and framework wrappers, keeping the public API surface consistent for PivotGrid consumers.

Changes:

  • Broadened dxPivotGridOptions.fieldChooser.height/width types from number to number | string in the public .d.ts sources and the aggregated dx.all.d.ts.
  • Updated Vue, React, and Angular wrapper typings/prop declarations to match the new number | string contract.

Reviewed changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/devextreme/ts/dx.all.d.ts Updates aggregated PivotGrid option typings for fieldChooser.height/width to number | string.
packages/devextreme/js/ui/pivot_grid.d.ts Updates the primary PivotGrid public .d.ts for fieldChooser.height/width to number | string.
packages/devextreme-vue/src/pivot-grid.ts Allows Vue wrapper nested fieldChooser height/width props to accept Number or String.
packages/devextreme-react/src/pivot-grid.ts Broadens React wrapper nested fieldChooser prop types to number | string.
packages/devextreme-angular/src/ui/pivot-grid/nested/field-chooser.ts Broadens Angular PivotGrid nested field chooser height/width inputs to number | string.
packages/devextreme-angular/src/ui/pivot-grid/index.ts Updates Angular PivotGrid component fieldChooser input/output typings to include string for height/width.
packages/devextreme-angular/src/ui/nested/field-chooser.ts Broadens shared Angular nested field chooser height/width inputs to number | string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants