PivotGrid - A11y: show a full focus outline on the field panel fields - #34595
Open
aleksei-semikozov wants to merge 6 commits into
Open
PivotGrid - A11y: show a full focus outline on the field panel fields#34595aleksei-semikozov wants to merge 6 commits into
aleksei-semikozov wants to merge 6 commits into
Conversation
added 2 commits
July 31, 2026 09:41
… the new field focus outline
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves PivotGrid keyboard accessibility by ensuring PivotGrid field panel items render a full, non-cropped focus outline when focused via keyboard navigation.
Changes:
- Added a
:focus-visibleoutline style for.dx-area-fieldso the focus indicator is drawn inside the field box. - Added an E2E TestCafe test validating the outline style and negative outline offset for keyboard-focused fields.
Reviewed changes
Copilot reviewed 2 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme-scss/scss/widgets/base/pivotGrid/_index.scss | Adds an inner (outline-offset: -2px) focus-visible outline for PivotGrid field panel fields. |
| e2e/testcafe-devextreme/tests/common/pivotGrid/kbn/fields.ts | Adds an E2E check to verify the focused field uses the intended outline styling. |
aleksei-semikozov
enabled auto-merge
August 3, 2026 18:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.