DataGrid: use mocked API response in RemoteGrouping demo test#34156
Queued
dmirgaev wants to merge 4 commits into
Queued
DataGrid: use mocked API response in RemoteGrouping demo test#34156dmirgaev wants to merge 4 commits into
dmirgaev wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the demos visual testing suite to make the DataGrid RemoteGrouping demo test deterministic by mocking the remote WidgetsGalleryDataService API, and adjusts skip lists to re-enable the demo in the test matrix.
Changes:
- Added a TestCafe
RequestMockand attached it to theDataGrid.RemoteGroupingfixture viarequestHooks. - Removed
RemoteGroupingfrom multiple skip lists so it can run in the visual test matrix. - Introduced a new API mock module that returns grouped payloads for the RemoteGrouping scenario.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| apps/demos/utils/visual-tests/matrix-test-helper.ts | Removes the default hardcoded skip for RemoteGrouping in the manual test runner. |
| apps/demos/testing/widgets/datagrid/RemoteGrouping.test.ts | Adds a request hook to run the RemoteGrouping screenshots against a mocked API. |
| apps/demos/testing/widgets/datagrid/apiMocks/remoteGroupingMock.ts | New TestCafe RequestMock returning grouped data tailored for the RemoteGrouping demo. |
| apps/demos/testing/skipped-tests.js | Re-enables RemoteGrouping in the common demo matrix by removing it from the skip list. |
6092cc1 to
b64864c
Compare
Raushen
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.