Remove lint npm script in favor of nx target#34145
Open
alexslavr wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the lint npm script from packages/devextreme/package.json and updates repository documentation to direct contributors to the Nx devextreme:lint target instead.
Changes:
- Removed
scripts.lintfrompackages/devextreme/package.json(previouslynx run devextreme:lint). - Updated
.github/copilot-instructions.mdto usepnpm nx run devextreme:lintfor devextreme linting. - Updated
CLAUDE.mdlint instructions (but currently uses an Nx command form that likely won’t run as written).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme/package.json | Removes the local lint npm script to encourage using Nx targets directly. |
| CLAUDE.md | Updates “all linting” command; currently missing the required project/target specification for Nx. |
| .github/copilot-instructions.md | Updates lint command guidance to use the Nx devextreme:lint target. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Alex Lavrov <36633600+alexslavr@users.noreply.github.com>
| **From `packages/devextreme`:** | ||
| ```bash | ||
| pnpm run lint # All linting | ||
| pnpm nx run devextreme:lint # All linting (aggregates lint-js, lint-ts, lint-dts, lint-texts) |
EugeniyKiyashko
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #34117