Skip to content

ArrayStore: Objects in nested array lose their type when array is updated (T1309567) #31884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ajivanyandev wants to merge 8 commits into
base: 25_2
Choose a base branch
from
Open

ArrayStore: Objects in nested array lose their type when array is updated (T1309567) #31884

ajivanyandev wants to merge 8 commits into from
+56 −1

Conversation

@ajivanyandev
Copy link
Contributor

@ajivanyandev ajivanyandev commented Nov 28, 2025

No description provided.

@ajivanyandev ajivanyandev self-assigned this Nov 28, 2025
Copilot AI review requested due to automatic review settings November 28, 2025 11:57
Copilot finished reviewing on behalf of ajivanyandev November 28, 2025 12:02
Copilot AI reviewed Nov 28, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the ArrayStore where objects in nested arrays would lose their custom prototypes (type information) when the array is updated. The fix preserves the prototype chain for non-plain objects during deep copy operations.

Key Changes

  • Modified getDeepCopyTarget function to preserve object prototypes using Object.create(Object.getPrototypeOf(item)) for non-plain objects
  • The fix aligns with existing patterns in the codebase (e.g., cloneInstanceWithChangedPaths in m_array_utils.ts)

Copilot AI review requested due to automatic review settings November 28, 2025 15:00
Copilot finished reviewing on behalf of ajivanyandev November 28, 2025 15:04
Copilot AI reviewed Nov 28, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings December 1, 2025 08:51
Copilot finished reviewing on behalf of ajivanyandev December 1, 2025 08:56
Copilot AI reviewed Dec 1, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Copilot AI review requested due to automatic review settings December 1, 2025 18:11
Copilot finished reviewing on behalf of ajivanyandev December 1, 2025 18:15
Copilot AI reviewed Dec 1, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@VasilyStrelyaev VasilyStrelyaev VasilyStrelyaev approved these changes

@GoodDayForSurf GoodDayForSurf GoodDayForSurf approved these changes

Assignees

@ajivanyandev ajivanyandev

Labels

25_2 force all tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ajivanyandev @VasilyStrelyaev @GoodDayForSurf