DataGrid - AI Column: Fix display of AI data during virtual scrolling #31876
+360
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the display of AI-generated data in DataGrid columns during virtual scrolling. When users scroll through a virtualized DataGrid with AI columns, the grid now properly detects viewport changes and sends AI requests for newly rendered rows.
Key Changes:
- Added viewport change detection mechanism to trigger AI requests during virtual scrolling
- Introduced
isCustomLoadingflag to distinguish between AI loading and default grid loading states - Enhanced test infrastructure to support AI column virtual scrolling tests
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
packages/testcafe-models/dataGrid/index.ts |
Updated LoadPanel selector to use dx-loadpanel class; added data and dataIndex to visible rows API; added apiPageIndex() method for testing |
packages/devextreme/testing/helpers/gridBaseMocks.js |
Added isCustomLoading() mock method to support testing custom loading states |
packages/devextreme/js/__internal/grids/grid_core/virtual_scrolling/m_virtual_scrolling.ts |
Made isViewportChanging() public with fallback to base implementation; updated setLoading() to respect custom loading state |
packages/devextreme/js/__internal/grids/grid_core/data_controller/m_data_controller.ts |
Added isCustomLoading() getter and isViewportChanging() extension point for virtual scrolling |
packages/devextreme/js/__internal/grids/grid_core/ai_column/controllers/m_ai_column_controller.ts |
Added viewport change listener to send AI requests during virtual scrolling; refactored request logic into reusable sendRequests() method |
e2e/testcafe-devextreme/tests/dataGrid/common/markup/markup.ts |
Updated test to use getContent() method instead of content property on LoadPanel |
e2e/testcafe-devextreme/tests/dataGrid/common/aiColumn/virtualScrolling.functional.ts |
Added comprehensive tests for AI column behavior during virtual scrolling with and without page index changes |
e2e/testcafe-devextreme/tests/dataGrid/common/aiColumn/pages/containerWithAIIntegration.html |
Added new test page that includes AI integration library for testing AI-related features |
...ges/devextreme/js/__internal/grids/grid_core/ai_column/controllers/m_ai_column_controller.ts
Outdated
Show resolved
Hide resolved
e2e/testcafe-devextreme/tests/dataGrid/common/aiColumn/virtualScrolling.functional.ts
Show resolved
Hide resolved
Raushen
reviewed
Nov 28, 2025
e2e/testcafe-devextreme/tests/dataGrid/common/aiColumn/pages/containerWithAIIntegration.html
Show resolved
Hide resolved
Raushen
reviewed
Nov 28, 2025
e2e/testcafe-devextreme/tests/dataGrid/common/aiColumn/virtualScrolling.functional.ts
Show resolved
Hide resolved
Raushen
reviewed
Nov 28, 2025
e2e/testcafe-devextreme/tests/dataGrid/common/aiColumn/virtualScrolling.functional.ts
Show resolved
Hide resolved
Raushen
reviewed
Nov 28, 2025
e2e/testcafe-devextreme/tests/dataGrid/common/aiColumn/virtualScrolling.functional.ts
Show resolved
Hide resolved
Raushen
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.