React - useImperativeHandle dependencies fix and useCallbacks' cleanup (T1308983) #31869
+145
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajivanyandev
changed the title
Copilot finished reviewing on behalf of
ajivanyandev
November 27, 2025 13:30
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes critical React hooks usage issues in the DevExtreme React wrapper core components by correcting useCallback and useImperativeHandle dependency arrays. The changes prevent unnecessary re-renders and stale closure bugs by implementing the proper pattern of using refs to track the latest function versions while keeping imperative handles stable.
- Removes incorrect mutable ref values from
useCallbackanduseImperativeHandledependency arrays - Implements the ref-tracking pattern to ensure imperative handles always call the latest function versions without recreating
- Adds test coverage to verify component refs remain accessible during controlled state updates
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme-react/src/core/extension-component.tsx | Fixed useCallback and useImperativeHandle dependencies; added ref-tracking pattern for createWidget |
| packages/devextreme-react/src/core/component.tsx | Fixed useCallback and useImperativeHandle dependencies; added ref-tracking pattern for createWidget and clearExtensions; modernized optional chaining syntax |
| packages/devextreme-react/src/core/component-base.tsx | Fixed multiple useCallback and useImperativeHandle dependencies; added ref-tracking patterns for createWidget and restoreParentLink |
| packages/devextreme-react/src/core/tests/test-component.tsx | Updated test component to follow the same ref-tracking pattern; added missing semicolon |
| packages/devextreme-react/src/core/tests/props-updating.test.tsx | Added test case to verify component refs remain defined during controlled selection updates; imported fireEvent |
VasilyStrelyaev
approved these changes
Dec 1, 2025
ajivanyandev
deleted the
cherry-pick-25-2/fix/react-ref-option-changed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.