Skip to content

Conversation

@VasilyStrelyaev
Copy link
Contributor

No description provided.

@VasilyStrelyaev VasilyStrelyaev self-assigned this Nov 27, 2025
Copilot AI review requested due to automatic review settings November 27, 2025 11:09
@VasilyStrelyaev VasilyStrelyaev changed the title fix: icons are not displayed in vite.js projects fix: icons are not displayed in vite.js projects (T1307744) Nov 27, 2025
Copilot finished reviewing on behalf of VasilyStrelyaev November 27, 2025 11:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where icons were not being displayed in Vite.js projects by renaming the icon fonts directory from icons to icon_fonts. This change resolves a conflict where Vite's default configuration treats directories named icons as containing SVG/image assets, which interferes with the proper loading of font files.

Key changes:

  • Renamed the icons directory to icon_fonts across the entire monorepo
  • Updated all references in SCSS files, build scripts, and tests to use the new directory name
  • Moved icon font files (.ttf, .woff, .woff2) to the new location

Reviewed changes

Copilot reviewed 7 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/devextreme/gulpfile.js Updated clean task to exclude icon_fonts directory instead of icons
packages/devextreme/build/gulp/npm.js Updated npm build task to copy from icon_fonts source path
packages/devextreme-themebuilder/tests/data/scss/widgets/generic/accordion/_index.scss Updated test SCSS file to reference icon_fonts in URL paths
packages/devextreme-scss/tests/icon-font.test.ts Updated test paths to reference icon_fonts directory for font files
packages/devextreme-scss/scss/widgets/base/_icons.scss Updated font-face URLs to use icon_fonts path
packages/devextreme-scss/project.json Updated Nx project inputs/outputs to track icon_fonts directory
packages/devextreme-scss/icon_fonts/dxiconsmaterial.woff2 Moved icon font file to new icon_fonts directory
packages/devextreme-scss/icon_fonts/dxiconsmaterial.woff Moved icon font file to new icon_fonts directory
packages/devextreme-scss/icon_fonts/dxiconsmaterial.ttf Moved icon font file to new icon_fonts directory
packages/devextreme-scss/build/style-compiler.js Updated gulp task to copy from icon_fonts directory

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copilot AI review requested due to automatic review settings November 27, 2025 12:11
@VasilyStrelyaev VasilyStrelyaev requested review from a team as code owners November 27, 2025 12:11
Copilot finished reviewing on behalf of VasilyStrelyaev November 27, 2025 12:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 133 out of 134 changed files in this pull request and generated 2 comments.


You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copilot AI review requested due to automatic review settings November 27, 2025 16:30
Copilot finished reviewing on behalf of VasilyStrelyaev November 27, 2025 16:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 133 out of 134 changed files in this pull request and generated no new comments.


You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copilot AI review requested due to automatic review settings November 28, 2025 12:50
Copilot finished reviewing on behalf of VasilyStrelyaev November 28, 2025 12:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 133 out of 134 changed files in this pull request and generated no new comments.


You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants