-
Notifications
You must be signed in to change notification settings - Fork 658
fix: icons are not displayed in vite.js projects (T1307744) #31860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: icons are not displayed in vite.js projects (T1307744) #31860
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes an issue where icons were not being displayed in Vite.js projects by renaming the icon fonts directory from icons to icon_fonts. This change resolves a conflict where Vite's default configuration treats directories named icons as containing SVG/image assets, which interferes with the proper loading of font files.
Key changes:
- Renamed the
iconsdirectory toicon_fontsacross the entire monorepo - Updated all references in SCSS files, build scripts, and tests to use the new directory name
- Moved icon font files (
.ttf,.woff,.woff2) to the new location
Reviewed changes
Copilot reviewed 7 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/gulpfile.js | Updated clean task to exclude icon_fonts directory instead of icons |
| packages/devextreme/build/gulp/npm.js | Updated npm build task to copy from icon_fonts source path |
| packages/devextreme-themebuilder/tests/data/scss/widgets/generic/accordion/_index.scss | Updated test SCSS file to reference icon_fonts in URL paths |
| packages/devextreme-scss/tests/icon-font.test.ts | Updated test paths to reference icon_fonts directory for font files |
| packages/devextreme-scss/scss/widgets/base/_icons.scss | Updated font-face URLs to use icon_fonts path |
| packages/devextreme-scss/project.json | Updated Nx project inputs/outputs to track icon_fonts directory |
| packages/devextreme-scss/icon_fonts/dxiconsmaterial.woff2 | Moved icon font file to new icon_fonts directory |
| packages/devextreme-scss/icon_fonts/dxiconsmaterial.woff | Moved icon font file to new icon_fonts directory |
| packages/devextreme-scss/icon_fonts/dxiconsmaterial.ttf | Moved icon font file to new icon_fonts directory |
| packages/devextreme-scss/build/style-compiler.js | Updated gulp task to copy from icon_fonts directory |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
72692d5 to
8e720e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 133 out of 134 changed files in this pull request and generated 2 comments.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
packages/devextreme-scss/scss/widgets/material/toolbar/_index.scss
Outdated
Show resolved
Hide resolved
packages/devextreme-scss/scss/widgets/fluent/toolbar/_index.scss
Outdated
Show resolved
Hide resolved
e0b32eb to
ff4f3ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 133 out of 134 changed files in this pull request and generated no new comments.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
ff4f3ee to
21f2125
Compare
21f2125 to
89981e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 133 out of 134 changed files in this pull request and generated no new comments.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
No description provided.