chore: add option to not throw error on user error in dvc js and react #1040
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
jsalaber
force-pushed
the
TSO-177-optional-throw-invalid-client-sdk
branch
from
922371c to
40c8b86
Compare
| @@ -105,7 +105,7 @@ export function initializeDevCycle< | |||
| | DevCycleOptionsWithDeferredInitialization, | |||
| optionsArg: DevCycleOptions = {}, | |||
| ): DevCycleClient<Variables, CustomData> { | |||
| if (!sdkKey) { | |||
| if (!sdkKey && optionsArg?.throwOnError) { | |||
There was a problem hiding this comment.
can we change this to have an IF statement inside which will at least this.logger.error instead of failing silently?
Also the throwOnError should default to true as that is our existing behaviour.
Suggested change
| if (!sdkKey && optionsArg?.throwOnError) { | |
| if (!sdkKey) { | |
| if (optionsArg?.throwOnError) { | |
| throw new UserError( | |
| 'Missing SDK key! Call initialize with a valid SDK key', | |
| ) | |
| } else { | |
| this.logger.error('Missing SDK key! Call initialize with a valid SDK key) | |
| } | |
| } |
| let sdkKey: string | ||
| if ('sdkKey' in config) { | ||
| sdkKey = config.sdkKey | ||
| } else { | ||
| sdkKey = config.envKey | ||
| } | ||
| if (!sdkKey) { | ||
| if (!sdkKey && !options?.throwOnError) { |
There was a problem hiding this comment.
similar to previous, split this into a nested IF which will log an error if the key is missing but throwOnError is false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
UserErrorif the user specifies option