Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): unable to start on Windows11 #290

Conversation

CoderSerio
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

在windows11上启动本项目会报错,详情见 issue #289

Issue Number: 289

What is the new behavior?

能够在windows11上正常启动

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

fix #289

Copy link

github-actions bot commented May 31, 2024

Website preview has been generated! 🎉 🎉 🎉

@xiejay97
Copy link
Member

你好,感谢pr,但是这里只是让代码运行,没有处理解决windows下的路径问题,这里是因为 windows 路径是 C:\repos\,Linux是这种 /dev/disk,用 http://nodejs.org/api/process.html#process_process_platform 判断处理一下

@xiejay97 xiejay97 merged commit 8e64f2e into DevCloudFE:main Jun 2, 2024
6 checks passed
@CoderSerio
Copy link
Contributor Author

你好,感谢pr,但是这里只是让代码运行,没有处理解决windows下的路径问题,这里是因为 windows 路径是 C:\repos\,Linux是这种 /dev/disk,用 http://nodejs.org/api/process.html#process_process_platform 判断处理一下

原来如此,感谢指点,已经进行了调整。不过我这里是使用path.sep替换了正则表达式中的/path.sep可以根据系统动态返回/\

话说回来,大佬的响应速度非常快啊,就在我还在写comment的时候,就已经merge完成!实在是非常惊人的响应速度!

@xiejay97
Copy link
Member

xiejay97 commented Jun 2, 2024

你好,感谢pr,但是这里只是让代码运行,没有处理解决windows下的路径问题,这里是因为 windows 路径是 C:\repos\,Linux是这种 /dev/disk,用 http://nodejs.org/api/process.html#process_process_platform 判断处理一下

原来如此,感谢指点,已经进行了调整。不过我这里是使用path.sep替换了正则表达式中的/path.sep可以根据系统动态返回/\

话说回来,大佬的响应速度非常快啊,就在我还在写comment的时候,就已经merge完成!实在是非常惊人的响应速度!

哈哈,感谢贡献,也是学习到了path.sep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: win11下启动项目时,代码报错
2 participants