fix(pipeline): reject non-HTTP slash arguments - #1389
Open
Yyunozor wants to merge 1 commit into
Open
Conversation
Signed-off-by: Yyunozor <yyunozor@icloud.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
arg_urlroutesRoot cause
detect_url_in_args()normalized every slash-prefixed call argument andcreated a
Routenode directly. That path bypassed the shared route-literalguard already used by the later route-node pass, so local filesystem paths and
regex operands could become
Routenodes andHTTP_CALLSedges.The change first rejects slash-prefixed raw expressions (string literals and
propagated constants are carried separately), routes the remaining heuristic
through the shared guard, and extends the callee filter to non-HTTP string
consumers such as
replace,match,search,test, andexec.Validation
scripts/test.sh --suites 'infrascan pipeline'— 241 passedsink(/<table/i)andtemplate.replace('/html/g', ...)cli(255 passed, 2 failed) anddaemon_runtime(42 passed, 1 failed)This addresses the
arg_urlregex/path bucket of #598. GraphQL andwhole-config-text classification remain out of scope.