Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyproject poetry mid update #295

Closed

Conversation

jake-aft
Copy link
Contributor

Current behaviour

New expected behaviour

Change logs

jake and others added 3 commits November 23, 2022 17:26
… a Pipfile updated .gitignore. Need to check some args in pre-commit-config not 100% clear on what is needed.
… a Pipfile updated .gitignore. Need to check some args in pre-commit-config not 100% clear on what is needed.
@jake-aft
Copy link
Contributor Author

@ceteri here is my WIP for the poetry conversion. pyproject.toml is in good order, I have not tested the package build as yet.

@jake-aft
Copy link
Contributor Author

jake-aft commented Nov 24, 2022

@ceteri I also have a Pipfile and have updated the README to include the new install instructions to install with pipenv and poetry. If it useful for you to take the pyproject.toml, and I'll do a diff merge request for these updates later. On slack if you need me.

@ceteri
Copy link
Collaborator

ceteri commented Nov 24, 2022

Thank you kindly @jake-aft
There are some outstanding issues in the comment threads on #275 and #294

The wheel builds just find, goes into PyPi fine, and I can run sample code with it from a download in a new env.

The source dist is the problem, currently the build tools seem to ignore commands to exclude/prune the unneeded directories – particularly the tests/ subdirectory which has ginormous benchmarks files for all of RDF and SPARQL.

@Mec-iS
Copy link
Contributor

Mec-iS commented Nov 29, 2022

please complete the issue's description

@jake-aft
Copy link
Contributor Author

jake-aft commented Dec 3, 2022

@ceteri and @Mec-iS I am splitting this into two PRS
POETRY AND PIPENV INSTALL
#299

I can follow up with the poetry build updates/PR it seems to work well and have not had the exclude / package size issues you were having with flint.

@ceteri please cancel this PR whenever you no longer need it as a reference.

@jake-aft
Copy link
Contributor Author

jake-aft commented Dec 4, 2022

This is split into two separate PRs
Poetry and pipenv install: #295
Poetry build: #300

@jake-aft jake-aft closed this Dec 11, 2022
@jake-aft jake-aft deleted the pyproject_poetry_mid_update branch December 11, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants