Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EMP Blast effect shader (Frontier #2262) #2762

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Jan 17, 2025

About the PR

Edited the EMP animation to have a nice look.

Why / Balance

It looked bad

Technical details

Swap the effect to a new one based on a shader, mostly reuse of the old rads storm one.

Media

File too large,
https://discord.com/channels/968983104247185448/1206353544186171482/1329881236864368693

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

I looks a bit off on low settings, but nothing I can do about it, looks fine on normal visual settings and high.

Changelog
🆑

  • tweak: EMP Pulse got a new visual look.

@dvir001 dvir001 requested review from a team as code owners January 17, 2025 18:33
@github-actions github-actions bot added S: Needs Review Changes: YML Changes any yml files Changes: C# Changes any cs files size/L 256-1023 lines Changes: Shaders Changes any swsl shaders labels Jan 17, 2025
Signed-off-by: Dvir <[email protected]>
Signed-off-by: Dvir <[email protected]>
Copy link
Contributor

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks amazing, hell yeah thank you for bringing this over

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Shaders Changes any swsl shaders Changes: YML Changes any yml files S: Needs Review size/L 256-1023 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants