Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported Starlight Signs #2741

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

rosieposieeee
Copy link
Contributor

@rosieposieeee rosieposieeee commented Jan 15, 2025

About the PR

Ported some of Starlight's signs, from ss14Starlight/space-station-14#240
Fixed the names & descriptions that didn't really match established style.
Left out the 'no smoking' sign, as we already had it.

In the image, I placed some relevant existing 'similar' signs, like the other clean hands sign, and the old dispo sign that I always thought was kind of ill-fitting.

image

NOTE: I hereby release all changes made in this PR under MIT license inasmuch as I am allowed to for a port. Might include the Starlight license, I don't know. I'm out of the equation, that's what matters.

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog
🆑 Conflee, rosieposieeee

  • add: Added some more signage for mappers.

@rosieposieeee rosieposieeee requested review from a team as code owners January 15, 2025 16:39
@github-actions github-actions bot added S: Needs Review size/M 64-255 lines Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an rsi labels Jan 15, 2025
Copy link
Contributor

RSI Diff Bot; head commit 7be1105 merging into 7ca7d9c
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_Starlight/Structures/Wallmounts/signs.rsi

State Old New Status
brigmed Added
calendar Added
cleanhands Added
disposals_proper Added
eyechart Added
secureareasmall Added
wall_biohazard Added
wall_extremeheat Added
yessmoking Added
youtoolpia Added

@rosieposieeee rosieposieeee changed the title added signs Ported Starlight Signs Jan 15, 2025
Copy link
Contributor

@Radezolid Radezolid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, comments could be multi line but I can fix those later with the DeltaV ones.

Copy link
Contributor

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve ops

@Radezolid Radezolid merged commit 7f70d1e into DeltaV-Station:master Jan 15, 2025
23 checks passed
@ilyamikcoder
Copy link
Contributor

this cool!

though i reckon the red brigmed sign doesn't match the security resprite #2695? might need to check that out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants