Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new pens for various departments #2735

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 57 additions & 1 deletion Resources/Prototypes/Entities/Objects/Devices/pda.yml
Radezolid marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,14 @@
- type: Pda
id: QuartermasterIDCard
state: pda-qm
#new delta v content
penSlot:
startingItem: PenLO
priority: -1
whitelist:
tags:
- Write
#end delta v content
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgor to change to # End DeltaV changes

- type: PdaBorderColor
borderColor: "#e39751"
accentVColor: "#a23e3e"
Expand Down Expand Up @@ -584,6 +592,14 @@
- type: Pda
id: CEIDCard
state: pda-ce
#new delta v content
penSlot:
startingItem: PenCE
priority: -1
whitelist:
tags:
- Write
#end delta v content
- type: PdaBorderColor
borderColor: "#949137"
accentHColor: "#447987"
Expand Down Expand Up @@ -614,6 +630,14 @@
- type: Pda
id: CMOIDCard
state: pda-cmo
#new delta v content
penSlot:
startingItem: PenCMO
priority: -1
whitelist:
tags:
- Write
#end delta v content
- type: PdaBorderColor
borderColor: "#d7d7d0"
accentHColor: "#447987"
Expand Down Expand Up @@ -678,7 +702,7 @@
- type: Icon
state: pda-chemistry

- type: entity
- type: entity
Radezolid marked this conversation as resolved.
Show resolved Hide resolved
parent: BasePDA
id: RnDPDA
name: mystagogue PDA # DeltaV - Epistemics Department replacing Science
Expand All @@ -687,6 +711,14 @@
- type: Pda
id: RDIDCard
state: pda-rd
#new delta v content
penSlot:
startingItem: PenMystagogue
priority: -1
whitelist:
tags:
- Write
#end delta v content
- type: PdaBorderColor
borderColor: "#d7d7d0"
accentHColor: "#447987"
Expand Down Expand Up @@ -732,6 +764,14 @@
- type: Pda
id: HoSIDCard
state: pda-hos
#new delta v content
penSlot:
startingItem: PenHos
priority: -1
whitelist:
tags:
- Write
#end delta v content
- type: PdaBorderColor
borderColor: "#A32D26"
accentHColor: "#447987"
Expand All @@ -756,6 +796,14 @@
- type: Pda
id: WardenIDCard
state: pda-warden
#new delta v content
penSlot:
startingItem: PenWarden
priority: -1
whitelist:
tags:
- Write
#end delta v content
- type: PdaBorderColor
borderColor: "#A32D26"
accentVColor: "#949137"
Expand Down Expand Up @@ -1027,6 +1075,14 @@
- type: Pda
id: PsychologistIDCard
state: pda-medical
#new delta v content
penSlot:
startingItem: PenPsych
priority: -1
whitelist:
tags:
- Write
#end delta v content
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments should be on the same indentation and should be formatted as such:

# Begin DeltaV changes
blah
blah
# End DeltaV changes

- type: PdaBorderColor
borderColor: "#d7d7d0"
accentVColor: "#447987"
Expand Down
91 changes: 81 additions & 10 deletions Resources/Prototypes/Entities/Objects/Misc/pen.yml
Radezolid marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,6 @@
damage:
types:
Piercing: 3
- type: Tending # Shitmed
speed: 0.55
- type: SurgeryTool # Shitmed
startSound:
path: /Audio/_Shitmed/Medical/Surgery/retractor1.ogg
endSound:
path: /Audio/_Shitmed/Medical/Surgery/hemostat1.ogg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restore this or explain why do you plan on removing this.
If you are trying to remove it you need to comment it out instead of deleting it,


#TODO: I want the luxury pen to write a cool font like Merriweather in the future.

Expand Down Expand Up @@ -116,13 +109,91 @@
description: A luxurious fountain pen for the captain of the station.
components:
- type: Sprite
state: pen_cap
state: pen_cap2

#new delta v pens
- type: entity
name: chief medical officer's pen
parent: PenEmbeddable
id: PenCMO
Radezolid marked this conversation as resolved.
Show resolved Hide resolved
description: A fancy ballpoint pen belonging to the chief medical officer. Used for writing "do no harm" on things.
components:
- type: Sprite
state: pen_cmo

- type: entity
name: psychologist's pen
parent: PenEmbeddable
id: PenPsych
description: A cheap ballpoint pen belonging to the Psychologist. Understands you better than anyone.
components:
- type: Sprite
state: pen_psych2

- type: entity
name: mystagogue's pen
parent: PenEmbeddable
id: PenMystagogue
description: An anomalous pen that may or may not have 0.001% chance of exploding when clicked.
components:
- type: Sprite
state: pen_mystagogue

- type: entity
name: head of security's pen
parent: PenEmbeddable
id: PenHos
description: A robust pen, your strongest tools for keeping the peace.
components:
- type: Sprite
state: pen_hos

- type: entity
name: warden's pen
parent: PenEmbeddable
id: PenWarden
description: An orderly pen that is chewed at the top from long hours in the office.
components:
- type: Sprite
state: pen_warden

- type: entity
name: chief engineer's pen
parent: PenEmbeddable
id: PenCE
description: Once belonging to an egghead, it now belongs to you. Solves practical problems.
components:
- type: Sprite
state: pen_ce


- type: entity
name: logistics officer's pen
parent: PenEmbeddable
id: PenLO
description: An efficient pen. Vital for writing strongly worded letters to Epistemics.
components:
- type: Sprite
state: pen_lo


- type: entity
name: hop's fountain pen
parent: PenEmbeddable
id: PenHop
description: A luxurious fountain pen for the hop of the station.
description: This pen looks oddly familiar...
components:
- type: Sprite
state: pen_hop2


- type: entity
name: chief justice's pen
parent: PenEmbeddable
id: PenCJ
description: A lawful pen adorned with a gold fountain tip.
components:
- type: Sprite
state: pen_hop
state: pen_cj

# end new delta v pens. hop pen and captain pens are changed from upstream.
10 changes: 9 additions & 1 deletion Resources/Prototypes/_DV/Entities/Objects/Devices/pda.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
id: ChiefJusticePDA
name: chief justice PDA
description: Whosoever bears this PDA is the law.
components:
components:
Radezolid marked this conversation as resolved.
Show resolved Hide resolved
- type: Sprite
sprite: _DV/Objects/Devices/pda.rsi
layers:
Expand All @@ -82,6 +82,14 @@
- type: Pda
id: ChiefJusticeIDCard
state: pda-chiefjustice
#new cj pen
penSlot:
startingItem: PenCJ
priority: -1
whitelist:
tags:
- Write
#end cj pen
Radezolid marked this conversation as resolved.
Show resolved Hide resolved
- type: PdaBorderColor
borderColor: "#470823"
- type: Icon
Expand Down
34 changes: 33 additions & 1 deletion Resources/Textures/Objects/Misc/pens.rsi/meta.json
Radezolid marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"version": 1,
"license": "CC-BY-SA-3.0",
"copyright": "Taken from tgstation at https://github.com/tgstation/tgstation/commit/e1142f20f5e4661cb6845cfcf2dd69f864d67432. pen_centcom is a resprited version of pen_cap by PuroSlavKing (Github). Luxury pen is drawn by Ubaser.",
"copyright": "Taken from tgstation at https://github.com/tgstation/tgstation/commit/e1142f20f5e4661cb6845cfcf2dd69f864d67432. pen_centcom is a resprited version of pen_cap by PuroSlavKing (Github). Luxury pen is drawn by Ubaser. pen_cap2, pen_hos2, lo, mysta, ce, hos, cj, warden and psych pens sprited by kushbreth.",
"size": {
"x": 32,
"y": 32
Expand All @@ -10,6 +10,34 @@
{
"name": "pen"
},

{
"name": "pen_cap2"
},
{
"name": "pen_hos"
},
{
"name": "pen_cmo"
},
{
"name": "pen_psych2"
},
{
"name": "pen_ce"
},
{
"name": "pen_hop2"
},
{
"name": "pen_lo"
},
{
"name": "pen_warden"
},
{
"name": "pen_mystagogue"
},
{
"name": "pen_cap"
},
Expand All @@ -24,6 +52,9 @@
},
{
"name": "luxury_pen"
},
{
"name": "pen_cj"
},
{
"name": "pen_blue"
Expand Down Expand Up @@ -55,5 +86,6 @@
"name": "pen_centcom-inhand-right",
"directions": 4
}

Radezolid marked this conversation as resolved.
Show resolved Hide resolved
]
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Resources/Textures/Objects/Misc/pens.rsi/pen_cj.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Resources/Textures/Objects/Misc/pens.rsi/pen_cmo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading