Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A small AAC update #2726

Closed
wants to merge 9 commits into from
Closed

Conversation

keekee38
Copy link

About the PR

Just added, modified, and reorganized some phrases for the AAC Tablet

Why / Balance

New roles have been added, and having used the AAC Tablet quite a bit, there were just some things I felt could be useful to have there.

Technical details

just some yaml and ftl stuff, first PR and I need to learn a ton of stuff so apologies if I messed anything up at all!

Media

some_new_words
actions section

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

N/A?

Changelog
🆑

  • tweak: Added, modified, and reorganized some phrases for the AAC Tablet

@keekee38 keekee38 requested review from a team as code owners January 14, 2025 07:24
@github-actions github-actions bot added S: Needs Review size/L 256-1023 lines Changes: YML Changes any yml files Changes: Localization Changes any ftl files and removed size/L 256-1023 lines labels Jan 14, 2025
@github-actions github-actions bot added the size/L 256-1023 lines label Jan 14, 2025
Copy link
Contributor

@Radezolid Radezolid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya, please fix these issues.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EoF newline required.

Comment on lines -48 to -50
phrase-safety-here-to-help = Here to help
phrase-safety-how-to-help = How can I help?
phrase-safety-evac = Let's evacuate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove these?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to me, they just felt a tiny bit redundant and a little outta place? but i can put them back sorry

parent: BaseCommonPhrase
group: Actions
abstract: true

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the double space here.

id: SwitchPhrase
parent: BaseActionPhrase
text: phrase-switch

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this double space.

id: FixPhrase
parent: BaseActionPhrase
text: phrase-fix

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this double space.

@@ -142,6 +152,11 @@
parent: BaseLogisticsJobPhrase
id: CourierPhrase
text: job-name-courier

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this double space.

@@ -191,6 +206,11 @@
parent: BaseMedicalJobPhrase
id: MedicalInternPhrase
text: job-name-intern

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this double space.

parent: BaseServiceJobPhrase
id: ServiceWorkerPhrase
text: job-name-serviceworker

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this double space.

parent: BaseCommandLocationPhrase
id: LocationAICorePhrase
text: station-beacon-ai-core

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this double space.

Comment on lines -416 to -425
- type: quickPhrase
parent: BaseServiceLocationPhrase
id: LocationJaniOfficePhrase
text: station-beacon-janitor-office

- type: quickPhrase
parent: BaseServiceLocationPhrase
id: LocationJaniClosetPhrase
text: station-beacon-janitor-closet

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do these need to be removed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can add those back too sorry

@github-actions github-actions bot added size/XL Over 1024 lines and removed size/L 256-1023 lines labels Jan 15, 2025
@keekee38
Copy link
Author

i keep messing stuff up somehow so gonna close it and probably retry it later sorry for everything

@keekee38 keekee38 closed this Jan 15, 2025
@keekee38 keekee38 deleted the maybe_aac_stuff branch January 15, 2025 02:30
@Radezolid
Copy link
Contributor

Oh, no worries, you can keep trying all you want. I don't mind reviewing stuff at all.

@keekee38 keekee38 mentioned this pull request Jan 16, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: YML Changes any yml files S: Needs Review size/XL Over 1024 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants