-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A small AAC update #2726
A small AAC update #2726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heya, please fix these issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EoF newline required.
phrase-safety-here-to-help = Here to help | ||
phrase-safety-how-to-help = How can I help? | ||
phrase-safety-evac = Let's evacuate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to me, they just felt a tiny bit redundant and a little outta place? but i can put them back sorry
parent: BaseCommonPhrase | ||
group: Actions | ||
abstract: true | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the double space here.
id: SwitchPhrase | ||
parent: BaseActionPhrase | ||
text: phrase-switch | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this double space.
id: FixPhrase | ||
parent: BaseActionPhrase | ||
text: phrase-fix | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this double space.
@@ -142,6 +152,11 @@ | |||
parent: BaseLogisticsJobPhrase | |||
id: CourierPhrase | |||
text: job-name-courier | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this double space.
@@ -191,6 +206,11 @@ | |||
parent: BaseMedicalJobPhrase | |||
id: MedicalInternPhrase | |||
text: job-name-intern | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this double space.
parent: BaseServiceJobPhrase | ||
id: ServiceWorkerPhrase | ||
text: job-name-serviceworker | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this double space.
parent: BaseCommandLocationPhrase | ||
id: LocationAICorePhrase | ||
text: station-beacon-ai-core | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this double space.
- type: quickPhrase | ||
parent: BaseServiceLocationPhrase | ||
id: LocationJaniOfficePhrase | ||
text: station-beacon-janitor-office | ||
|
||
- type: quickPhrase | ||
parent: BaseServiceLocationPhrase | ||
id: LocationJaniClosetPhrase | ||
text: station-beacon-janitor-closet | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do these need to be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i can add those back too sorry
…into maybe_aac_stuff
Signed-off-by: keekee38 <[email protected]>
i keep messing stuff up somehow so gonna close it and probably retry it later sorry for everything |
Oh, no worries, you can keep trying all you want. I don't mind reviewing stuff at all. |
About the PR
Just added, modified, and reorganized some phrases for the AAC Tablet
Why / Balance
New roles have been added, and having used the AAC Tablet quite a bit, there were just some things I felt could be useful to have there.
Technical details
just some yaml and ftl stuff, first PR and I need to learn a ton of stuff so apologies if I messed anything up at all!
Media
Requirements
Breaking changes
N/A?
Changelog
🆑