Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listening post rewrite #1369

Merged
merged 12 commits into from
Jun 13, 2024
Merged

Conversation

deltanedas
Copy link
Member

@deltanedas deltanedas commented Jun 13, 2024

About the PR

  • rewrite everything about listening post
  • the rule uses AntagSelection
  • AutoTraitor removed, they are no longer tators they have their own role now
    fixes Listening post causes Traitorloose #1275
  • any internals calling it "pirate radio" have been renamed, including the map file's path

in the future they can have funny objectives that make sense for the role and not things like steal the caps laser which would break the ghost roles rules of not revealing yourself

Why / Balance

listening post having tc is bad, and telegnome ops having infinite tc is really bad

Technical details

  • loading a grid far away is now LoadFarGridRule
  • debris spawning is now DebrisSpawnerRule
  • the old pirate radio spawn rule go poof as a result

Media

roles are real
01:53:34

no uplink no fun
01:54:57

greentext or redtext???
01:55:14

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

everything listening post related

Changelog
🆑

  • fix: Fixed listening post ops having TC and being counted as traitors.

@github-actions github-actions bot added Changes: YML Changes any yml files Changes: Map Changes: C# Changes any cs files Changes: Localization Changes any ftl files labels Jun 13, 2024
@deltanedas deltanedas marked this pull request as ready for review June 13, 2024 00:55
@ghost ghost mentioned this pull request Jun 13, 2024
@DangerRevolution
Copy link
Contributor

o7

@Lyndomen
Copy link
Member

Is having TC bad? We generally saw some cool strats, with the LP sending a reinforcement wave at the station in bootleg attacks.

@pissdemon
Copy link
Contributor

Yeah, I don't think it's bad in and of itself. It's great for defense too. My last LP round, Sec metagamed our existence and conducted a raid, and I bought a Syndicate bomb which ended up killing three of the raiders. And the ability to buy reinforcements allows more flexibility when assisting on-board Syndicate. Fake traders, sending fake GALPOL to help a fugitive escape, etc.

@Bonktrauma
Copy link
Contributor

Is having TC bad? We generally saw some cool strats, with the LP sending a reinforcement wave at the station in bootleg attacks.

Honestly, I'd agree, however the TC duplication does need fixed

@NullWanderer NullWanderer merged commit 5e812e0 into DeltaV-Station:master Jun 13, 2024
11 checks passed
@deltanedas deltanedas deleted the post-ops branch June 13, 2024 18:51
@deltanedas
Copy link
Member Author

LPs rules explicitly say to keep the LP a secret, sending reinforcements to raid the station is the opposite of that. if they need more guns for self defence just give them more

@WarMechanic
Copy link
Contributor

well i mean if you don't see any ties to the LP on the reinforcements then you shouldn't know it exists so it seems fine in my book

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Map Changes: YML Changes any yml files Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listening post causes Traitorloose
7 participants