Added Costumes/Clothing and Fixes #209

ps3moira · 2023-10-04T12:13:25Z

About the PR

added among grande costume
added skeleton costume
swapped sprite salvage jumpsuit sprites
added more supplies to salvage vend
added clothing to clothesmate
removed clothing to clothesmate
added clothing to winterdrobe
added clothing to secdrobe
added cc armored winter coat to centdrobe
added hos's mantle +flask to their locker
added mystagogue's resprited cloak to their locker

Media

Changelog

🆑

add: Added Among Grande and Skeleton Costume
add: Added Costumes and Clothing to Vends
tweak: Salvage Jumpsuit Sprites
tweak: Added Salvage Jumpsuit and Gear to Salvage Vend

DEATHB4DEFEAT

You need to install EditorConfig

Resources/Prototypes/DeltaV/Entities/Clothing/OuterClothing/vests.yml

Resources/Prototypes/DeltaV/Entities/Clothing/Head/hoods.yml

Resources/Prototypes/DeltaV/Entities/Clothing/Head/hats.yml

Resources/Prototypes/Catalog/VendingMachines/Inventories/salvage.yml

Resources/Prototypes/Entities/Clothing/OuterClothing/coats.yml

Resources/Textures/DeltaV/Clothing/OuterClothing/Coats/skeletoncostume.rsi/meta.json

Resources/Textures/DeltaV/Clothing/OuterClothing/Vests/amonggrande.rsi/meta.json

…sts.yml Co-authored-by: DEATHB4DEFEAT <[email protected]>

Co-authored-by: DEATHB4DEFEAT <[email protected]>

…ge.yml Co-authored-by: DEATHB4DEFEAT <[email protected]>

…ande.rsi/meta.json Co-authored-by: DEATHB4DEFEAT <[email protected]>

Co-authored-by: DEATHB4DEFEAT <[email protected]>

…ncostume.rsi/meta.json Co-authored-by: DEATHB4DEFEAT <[email protected]>

ps3moira · 2023-10-05T02:38:07Z

You need to install EditorConfig

Is that required to make this PR work?

DEATHB4DEFEAT · 2023-10-13T22:14:42Z

You need to install EditorConfig

Is that required to make this PR work?

No it's just a good extension to have, fixes some formatting mistakes to follow project standards

DEATHB4DEFEAT · 2023-10-13T22:16:01Z

add: Among Grande and Skeleton Costumes

add: Costumes and Clothing to Vends

tweak: Salvage Jumpsuit Sprites

Don't consider the entry type suffix (e.g. add) to be "part" of the sentence:
bad: - add: a new tool for engineers
good: - add: Added a new tool for engineers

You need to fix your changelogs

Resources/Prototypes/Catalog/VendingMachines/Inventories/salvage.yml

Resources/Prototypes/DeltaV/Entities/Clothing/Head/hats.yml

Resources/Prototypes/DeltaV/Entities/Clothing/Head/hoods.yml

DEATHB4DEFEAT · 2023-10-13T22:20:56Z

Resources/Prototypes/Entities/Clothing/Head/hats.yml

@@ -650,7 +650,7 @@
 - type: entity
  parent: ClothingHeadBase
  id: ClothingHeadHatTacticalMaidHeadband
-  name: tactical maid headband
+  name: red headband


Suggested change

name: red headband

name: tactical maid headband

Would renaming it to red headband not be good? Tactical maid headband doesn't really make sense to me for what it looks like and what the description is.

Resources/Prototypes/Entities/Clothing/Uniforms/jumpsuits.yml

DEATHB4DEFEAT · 2023-10-13T22:22:21Z

Resources/Textures/Clothing/Head/Hats/cardborg_h.rsi/meta.json

@@ -1,7 +1,7 @@
 {
  "version": 1,
  "license": "CC-BY-SA-3.0",
-  "copyright": "Taken from tgstation at commit https://github.com/tgstation/tgstation/commit/4f6190e2895e09116663ef282d3ce1d8b35c032e",
+  "copyright": "Made by @ps3moira#9488",


No sprites were changed, is this correct?

No that is not whoops

DEATHB4DEFEAT · 2023-10-13T22:23:06Z

Resources/Textures/Clothing/Head/Hats/legionnaireheadpiece.rsi - Copy/icon.png

File path is incorrect and contains a space.

DEATHB4DEFEAT · 2023-10-13T22:23:33Z

Resources/Textures/Clothing/OuterClothing/Coats/suspiciouscostume.rsi/icon.png

Move to DeltaV folder.

…ge.yml Co-authored-by: DEATHB4DEFEAT <[email protected]>

Co-authored-by: DEATHB4DEFEAT <[email protected]>

Added Costumes/Clothing and Added Fixes

0d7d05a

github-actions bot added Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files labels Oct 4, 2023

Merge branch 'master' into COSTUMES+FIXES

41f24e2

DEATHB4DEFEAT suggested changes Oct 5, 2023

View reviewed changes

ps3moira and others added 7 commits October 4, 2023 18:58

Update Resources/Prototypes/DeltaV/Entities/Clothing/OuterClothing/ve…

851dd54

…sts.yml Co-authored-by: DEATHB4DEFEAT <[email protected]>

Update Resources/Prototypes/DeltaV/Entities/Clothing/Head/hoods.yml

7d3752e

Co-authored-by: DEATHB4DEFEAT <[email protected]>

Update Resources/Prototypes/DeltaV/Entities/Clothing/Head/hats.yml

d2a3968

Co-authored-by: DEATHB4DEFEAT <[email protected]>

Update Resources/Prototypes/Catalog/VendingMachines/Inventories/salva…

fae945f

…ge.yml Co-authored-by: DEATHB4DEFEAT <[email protected]>

Update Resources/Textures/DeltaV/Clothing/OuterClothing/Vests/amonggr…

77913bd

…ande.rsi/meta.json Co-authored-by: DEATHB4DEFEAT <[email protected]>

Update Resources/Prototypes/Entities/Clothing/OuterClothing/coats.yml

5c670f6

Co-authored-by: DEATHB4DEFEAT <[email protected]>

Update Resources/Textures/DeltaV/Clothing/OuterClothing/Coats/skeleto…

e02f3ac

…ncostume.rsi/meta.json Co-authored-by: DEATHB4DEFEAT <[email protected]>

ps3moira requested a review from DEATHB4DEFEAT October 5, 2023 22:45

github-actions bot added the Status: Needs Review Someone please review this label Oct 5, 2023

Fixed In-Hand Sprite for Among Grande

184119e

DEATHB4DEFEAT suggested changes Oct 13, 2023

View reviewed changes

ps3moira and others added 7 commits October 13, 2023 15:28

Update Resources/Prototypes/Catalog/VendingMachines/Inventories/salva…

8ec889c

…ge.yml Co-authored-by: DEATHB4DEFEAT <[email protected]>

Update Resources/Prototypes/DeltaV/Entities/Clothing/Head/hats.yml

b39635f

Co-authored-by: DEATHB4DEFEAT <[email protected]>

Update Resources/Prototypes/DeltaV/Entities/Clothing/Head/hats.yml

824931a

Co-authored-by: DEATHB4DEFEAT <[email protected]>

Update Resources/Prototypes/DeltaV/Entities/Clothing/Head/hats.yml

3f3d71a

Co-authored-by: DEATHB4DEFEAT <[email protected]>

Update Resources/Prototypes/DeltaV/Entities/Clothing/Head/hoods.yml

43e171d

Co-authored-by: DEATHB4DEFEAT <[email protected]>

Update Resources/Prototypes/Entities/Clothing/Uniforms/jumpsuits.yml

2ee6b49

Co-authored-by: DEATHB4DEFEAT <[email protected]>

Merge remote-tracking branch 'upstream/master' into COSTUMES+FIXES

d2bcd09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Costumes/Clothing and Fixes #209

Added Costumes/Clothing and Fixes #209

ps3moira commented Oct 4, 2023 •

edited

Loading

DEATHB4DEFEAT left a comment

ps3moira commented Oct 5, 2023

DEATHB4DEFEAT commented Oct 13, 2023

DEATHB4DEFEAT commented Oct 13, 2023

DEATHB4DEFEAT Oct 13, 2023

ps3moira Oct 13, 2023

DEATHB4DEFEAT Oct 13, 2023

ps3moira Oct 13, 2023

DEATHB4DEFEAT Oct 13, 2023

DEATHB4DEFEAT Oct 13, 2023

Added Costumes/Clothing and Fixes #209

Are you sure you want to change the base?

Added Costumes/Clothing and Fixes #209

Conversation

ps3moira commented Oct 4, 2023 • edited Loading

About the PR

DEATHB4DEFEAT left a comment

Choose a reason for hiding this comment

ps3moira commented Oct 5, 2023

DEATHB4DEFEAT commented Oct 13, 2023

DEATHB4DEFEAT commented Oct 13, 2023

DEATHB4DEFEAT Oct 13, 2023

Choose a reason for hiding this comment

ps3moira Oct 13, 2023

Choose a reason for hiding this comment

DEATHB4DEFEAT Oct 13, 2023

Choose a reason for hiding this comment

ps3moira Oct 13, 2023

Choose a reason for hiding this comment

DEATHB4DEFEAT Oct 13, 2023

Choose a reason for hiding this comment

DEATHB4DEFEAT Oct 13, 2023

Choose a reason for hiding this comment

ps3moira commented Oct 4, 2023 •

edited

Loading