Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do ui 4 #7

Merged
merged 3 commits into from
Oct 23, 2019
Merged

Do ui 4 #7

merged 3 commits into from
Oct 23, 2019

Conversation

GFibrizo
Copy link
Collaborator

@GFibrizo GFibrizo commented Oct 22, 2019 •
edited
Loading

  • Addresses issue Change to linking flow data-owner#3
  • Fixes communication between UI and API inside container. The UI now points to the proxy server instead of pointing to the container-internal API port (there was a harcoded port 5000 in the UI code).
  • Improves user experience by changing the BrowserRoute for a HashRoute in the UI and by removing redirects (review if this is ok).

Should be merge at the same time that DeltaML/data-owner#19

@GFibrizo GFibrizo added the enhancement New feature or request label Oct 22, 2019
@GFibrizo GFibrizo requested a review from agrojas October 22, 2019 06:22
@GFibrizo GFibrizo self-assigned this Oct 22, 2019
@GFibrizo GFibrizo mentioned this pull request Oct 22, 2019
Merged
@agrojas agrojas merged commit 95b6f1a into master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrojas agrojas agrojas approved these changes

Assignees

@GFibrizo GFibrizo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GFibrizo @agrojas