-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(body): added additional attribute '--body' to dsv secret create & dsv home c… #134
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
===========================================
+ Coverage 32.61% 51.09% +18.48%
===========================================
Files 80 87 +7
Lines 10855 11964 +1109
===========================================
+ Hits 3540 6113 +2573
+ Misses 7027 5551 -1476
- Partials 288 300 +12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pacificcode try running trunk check
locally and should get 3 items flagged. Maybe existing code or not. If you need to add an exception you can document why that's a legit exception to bypass the check using the //nolint:<linter> // documented reason why no lint shouldn't apply
. Try to resolve if straight-forward, low effort, otherwise document why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Then only minor thing is that I think it is a good idea to use any
instead of interface{}
. If you update that then I'll re-approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a failed checksum with Aqua in actions try Aqua update-checksum -prune and see if that file failed to get updated. It's a verification step so probably l missed being updated.
Don't forget to run changie new for chabgekog entry as well.
I see the test action failed. That's the first time I've ever seen that message and has to do with the signature for Aqua tool (a safety net for verifying the binary). I'll look at this and post an update today after checking into it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending batch commit changes and then this can be merged.
Co-authored-by: sheldonhull <[email protected]>
Co-authored-by: sheldonhull <[email protected]>
added additional attribute '--body' to dsv secret create & dsv home.
Lint future work: AB#561862 AB#561861