Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(body): added additional attribute '--body' to dsv secret create & dsv home c… #134

Merged
merged 14 commits into from
Mar 28, 2024

Conversation

pacificcode
Copy link
Contributor

@pacificcode pacificcode commented Mar 15, 2024

added additional attribute '--body' to dsv secret create & dsv home.

Lint future work: AB#561862 AB#561861

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 48.00000% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 51.09%. Comparing base (a2521eb) to head (f41db62).
Report is 94 commits behind head on main.

Files Patch % Lines
commands/secret.go 40.00% 10 Missing and 2 partials ⚠️
format/writers.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #134       +/-   ##
===========================================
+ Coverage   32.61%   51.09%   +18.48%     
===========================================
  Files          80       87        +7     
  Lines       10855    11964     +1109     
===========================================
+ Hits         3540     6113     +2573     
+ Misses       7027     5551     -1476     
- Partials      288      300       +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pacificcode pacificcode changed the title add(body): added additional attribute '--body' to dsv secret create & dsv home c… feat(body): added additional attribute '--body' to dsv secret create & dsv home c… Mar 15, 2024
Copy link
Contributor

@sheldonhull sheldonhull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pacificcode try running trunk check locally and should get 3 items flagged. Maybe existing code or not. If you need to add an exception you can document why that's a legit exception to bypass the check using the //nolint:<linter> // documented reason why no lint shouldn't apply. Try to resolve if straight-forward, low effort, otherwise document why.

Copy link
Contributor

@andrii-zakurenyi andrii-zakurenyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Then only minor thing is that I think it is a good idea to use any instead of interface{}. If you update that then I'll re-approve.

commands/secret.go Outdated Show resolved Hide resolved
Copy link
Contributor

@sheldonhull sheldonhull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a failed checksum with Aqua in actions try Aqua update-checksum -prune and see if that file failed to get updated. It's a verification step so probably l missed being updated.

Don't forget to run changie new for chabgekog entry as well.

@sheldonhull
Copy link
Contributor

I see the test action failed. That's the first time I've ever seen that message and has to do with the signature for Aqua tool (a safety net for verifying the binary). I'll look at this and post an update today after checking into it.

format/writers.go Outdated Show resolved Hide resolved
utils/env.go Outdated Show resolved Hide resolved
Copy link
Contributor

@sheldonhull sheldonhull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending batch commit changes and then this can be merged.

format/writers.go Outdated Show resolved Hide resolved
utils/env.go Outdated Show resolved Hide resolved
@sheldonhull sheldonhull enabled auto-merge (squash) March 26, 2024 20:29
pacificcode and others added 2 commits March 27, 2024 06:21
Co-authored-by: sheldonhull <[email protected]>
Co-authored-by: sheldonhull <[email protected]>
@sheldonhull sheldonhull merged commit 28d32e3 into main Mar 28, 2024
12 checks passed
@sheldonhull sheldonhull deleted the bh.secret.body branch March 28, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants