Skip to content

Conversation

@jakebailey
Copy link
Member

This package sets the cursed combo of strictNullChecks=false and noImplicitAny=true while using null. Just work around this inference change in the test.

microsoft/TypeScript#62243

@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 12, 2025

@jakebailey Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners, DT maintainers or others

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 74213,
  "author": "jakebailey",
  "headCommitOid": "d207b50f5feef5f6e26154241df2c14619517fbc",
  "mergeBaseOid": "c50862c2aee7eb160ca6632d089227c20587eb71",
  "lastPushDate": "2025-12-12T17:21:58.000Z",
  "lastActivityDate": "2025-12-12T17:21:58.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "jqrangeslider",
      "kind": "edit",
      "files": [
        {
          "path": "types/jqrangeslider/jqrangeslider-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "qcz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 3647454543,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @qcz — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@jakebailey jakebailey merged commit 50dfecb into DefinitelyTyped:master Dec 12, 2025
4 checks passed
@jakebailey jakebailey deleted the jqrangeslider branch December 12, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants