CI fixes #392
Open
CI fixes #392
+14
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardrf
approved these changes
Jun 5, 2025
lionello
had a problem deploying
to
deploy-changed-samples
GitHub Actions
Error
lionello
had a problem deploying
to
deploy-changed-samples
GitHub Actions
Failure
raphaeltm
reviewed
Jun 16, 2025
| "dev": "next dev", | ||
| "build": "next build", | ||
| "start": "next start", | ||
| "start": "exec next start", |
There was a problem hiding this comment.
@lionello why exec? That's not standard.
raphaeltm
reviewed
Jun 16, 2025
| # run: | | ||
| # eval "$(curl -fsSL s.defang.io/install)" | ||
| # cat modified.txt | xargs -n1 defang compose config -C > /dev/null | ||
| - name: Validate Compose Files with Defang CLI |
There was a problem hiding this comment.
@lionello not sure we need this: it's currently checked by the deploy_changed_samples. Though... that one is erroring with:
2025/06/16 17:11:08 Deployer 0: failed to run test crew-django-redis-postgres: failed to load configs for test crew-django-redis-postgres: failed to load project: validating /home/runner/work/samples/samples/samples/crew-django-redis-postgres/compose.yaml: services.embedding Additional property provider is not allowed
So if this one takes into account the new provider property, then maybe we switch it?
lionello
had a problem deploying
to
deploy-changed-samples
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Samples Checklist