Skip to content

Conversation

@renatodellosso
Copy link
Contributor

No description provided.

@renatodellosso renatodellosso added the feature improvement Improve an existing feature label Apr 11, 2025
@renatodellosso renatodellosso self-assigned this Apr 11, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (1)

tests/unit/lib/DbInterfaceAuthAdapter.test.ts:267

  • The test manually assigns the id from _id; consider ensuring that the adapter itself automatically maps _id to id, so that tests do not need to adjust the data manually.
foundUser!.id = foundUser!._id!.toString();

@renatodellosso renatodellosso requested a review from Copilot April 17, 2025 21:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the auth adapter and related tests so that its behavior conforms to the Mongo adapter. Key changes include:

  • Updating calls to getUserByAccount to pass explicit provider and providerAccountId properties.
  • Removing tests that check for error conditions on missing or non-existent user/session identifiers.
  • Adding new API methods (e.g., addOrUpdateObject, findObjectAndUpdate, deleteObjects, findObjectAndDelete) to various DbInterface classes and updating related type definitions.

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/unit/lib/DbInterfaceAuthAdapter.test.ts Updated tests and removed redundant error handling tests; adjusted getUserByAccount calls.
lib/client/dbinterfaces/LocalStorageDbInterface.ts Added new DbInterface methods wrapping super calls.
lib/client/dbinterfaces/InMemoryDbInterface.ts Added new DbInterface methods wrapping super calls.
lib/client/dbinterfaces/DbInterface.ts Extended interface definitions with new methods.
lib/client/dbinterfaces/CachedDbInterface.ts Added new DbInterface methods wrapping super calls.
lib/Utils.ts Included emailVerified in user field population.
lib/Types.ts Added emailVerified property to the User type.
lib/Auth.ts Removed custom profile functions for Google and Slack providers to conform to the Mongo adapter.
Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (1)

tests/unit/lib/DbInterfaceAuthAdapter.test.ts:266

  • [nitpick] Consider clarifying or removing the comment about 'id' behavior to ensure consistent expectations in test assertions.
// Not sure how id behaves, don't use it

@renatodellosso renatodellosso merged commit a000f4c into main May 1, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature improvement Improve an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants