-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: chip implementation for uikit #111
Conversation
@daniel-dumortier, I have some issues with the current chips: Thanks |
@SimonLeclercq
I decided to implement the more complex one ;). Regarding the input variant : |
@daniel-dumortier yes I mean Well noted regarding the two sources of truth, I'll take this point. Issue here: Decathlon/vitamin-design#191 I'll take a look a callback and give you more detail as soon as possible 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daniel-dumortier, discuss with team, the 'tag' inside filter variant is a miss (copy from web, but not available for mobile.). In this way, can you delete it?
Apart from that, it's good for me 🚀
@SimonLeclercq Done, the badge has been removed, you can find the last showcase on slack |
Co-authored-by: Florent LOTTHÉ <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Changes description
This PR adds the Chip component for UIKit version.
Context
Implements the UIKit part of issue #20
Checklist
design-system-core-team-design
GitHub team.Does this introduce a breaking change?
Screenshots
iPhone
iPad
Other information