Buy sell panel slider #568
Conversation
Deploying dexter with
|
| Latest commit: |
37b6816
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6c4dad38.dexter-1we.pages.dev |
| Branch Preview URL: | https://buy-sell-panel-slider.dexter-1we.pages.dev |
…sell-panel-slider
|
Some feedback:
|
src/app/styles/globals.css
Outdated
There was a problem hiding this comment.
Is it possible to make those classes inline tailwind CSS classes instead of using global classes?
If you run into the issue that they are not applied or overwritten, you can always try adding ! before the class, so it becomes !important.
| isBuyOrder: boolean; | ||
| isSellOrder: boolean; |
There was a problem hiding this comment.
Should this be
isMarketBuyOrder
isMarketSellOrder
?
Or are we using those booleans also for LIMIT orders?
There was a problem hiding this comment.
@saidam90 can you comment on this?
| } else if (isLimitOrder) { | ||
| sliderCallback(0, "LIMIT"); | ||
| } | ||
| }, [isBuyOrder, isSellOrder, isMarketOrder, isLimitOrder]); |
There was a problem hiding this comment.
React Hook useEffect has a missing dependency: 'sliderCallback'. Either include it or remove the dependency array
| }, [isBuyOrder, isSellOrder, isMarketOrder, isLimitOrder]); | ||
|
|
||
| const sliderCallback = (newPercentage: number, type: string) => { | ||
| console.log(`Type is: ${type}`); |
| @@ -479,7 +541,15 @@ function UserInputContainer() { | |||
| <> | |||
| <CurrencyInputGroup userAction={UserAction.UPDATE_PRICE} /> | |||
| <CurrencyInputGroup userAction={UserAction.SET_TOKEN_1} /> | |||
| <PercentageSlider /> | |||
There was a problem hiding this comment.
The percentage slider in market orders should be below the input field, not above.
|
|
||
| return ( | ||
| <> | ||
| <div className="slider-container rounded-md w-full relative mt-5"> |
There was a problem hiding this comment.
can you make the full slider opacity of 0.7, currently there is too much emphasis on it.
| <div className="slider-container rounded-md w-full relative mt-5"> | |
| <div className="slider-container rounded-md w-full relative mt-5 opacity-70"> |
Implemented Buy/Sell panel percentage slider.