Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move attributes into CCustomCSView #2685

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Move attributes into CCustomCSView #2685

wants to merge 11 commits into from

Conversation

Bushstar
Copy link
Member

@Bushstar Bushstar commented Nov 7, 2023

Summary

  • Moves attributes into CCustomCSView
  • Removes the need to load ATTRIBUTES from the view as keys and values can be checked, retrieved, set, erased or looped through via the view itself.
  • Attributes are loaded into CCustomCSView on demand and are passed on to copies of CCustomCSView. On Flush or before Flush if an undo is to be created the changes in the attribute copy is applied.
  • Note that after Flush the copy in the parent is cleared with ClearAttributes(), this happen outside of SetAttributes(), but should be moved into it to avoid having to add these additional calls or update the parent copy.
  • Change BlockContext argument to CreateToken to a reference.
  • Move attribute types to its own file. Not needed but tidier.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@Bushstar Bushstar removed the ci/sync label Jan 29, 2024
@prasannavl prasannavl added the e4 High effort // takes lot of time or high expertise label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e4 High effort // takes lot of time or high expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants