Refactor getEvents slightly to avoid modifying the MicromarkParseOpti…

…ons object.
DavidAnson · Oct 23, 2024 · d94b78e · d94b78e
1 parent 38b4ec0
commit d94b78e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/demo/markdownlint-browser.js b/demo/markdownlint-browser.js
@@ -1023,15 +1023,15 @@ function getEvents(
   markdown,
   micromarkParseOptions = {}
 ) {
-  // Customize options object to add useful extensions
-  micromarkParseOptions.extensions = micromarkParseOptions.extensions || [];
-  micromarkParseOptions.extensions.push(
+  // Customize extensions list to add useful extensions
+  const extensions = [
     micromark.directive(),
     micromark.gfmAutolinkLiteral(),
     micromark.gfmFootnote(),
     micromark.gfmTable(),
-    micromark.math()
-  );
+    micromark.math(),
+    ...(micromarkParseOptions.extensions || [])
+  ];
 
   // // Shim labelEnd to identify undefined link labels
   /** @type {Event[][]} */
@@ -1153,7 +1153,7 @@ function getEvents(
     // Use micromark to parse document into Events
     const encoding = undefined;
     const eol = true;
-    const parseContext = micromark.parse(micromarkParseOptions);
+    const parseContext = micromark.parse({ ...micromarkParseOptions, extensions });
     const chunks = micromark.preprocess()(markdown, encoding, eol);
     const events = micromark.postprocess(parseContext.document().write(chunks));
 

diff --git a/helpers/micromark-parse.cjs b/helpers/micromark-parse.cjs
@@ -32,15 +32,15 @@ function getEvents(
   markdown,
   micromarkParseOptions = {}
 ) {
-  // Customize options object to add useful extensions
-  micromarkParseOptions.extensions = micromarkParseOptions.extensions || [];
-  micromarkParseOptions.extensions.push(
+  // Customize extensions list to add useful extensions
+  const extensions = [
     micromark.directive(),
     micromark.gfmAutolinkLiteral(),
     micromark.gfmFootnote(),
     micromark.gfmTable(),
-    micromark.math()
-  );
+    micromark.math(),
+    ...(micromarkParseOptions.extensions || [])
+  ];
 
   // // Shim labelEnd to identify undefined link labels
   /** @type {Event[][]} */
@@ -162,7 +162,7 @@ function getEvents(
     // Use micromark to parse document into Events
     const encoding = undefined;
     const eol = true;
-    const parseContext = micromark.parse(micromarkParseOptions);
+    const parseContext = micromark.parse({ ...micromarkParseOptions, extensions });
     const chunks = micromark.preprocess()(markdown, encoding, eol);
     const events = micromark.postprocess(parseContext.document().write(chunks));