Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netstandard 2.1 #26

Merged
merged 10 commits into from
Nov 2, 2020
Merged

Netstandard 2.1 #26

merged 10 commits into from
Nov 2, 2020

Conversation

Nihlus
Copy link
Contributor

@Nihlus Nihlus commented Jul 29, 2020

This PR enables building the package for .NET Standard 2.1, as well as building it on non-windows platforms without Mono installed.

Supersedes #21.

EDIT:
After more investigation, this PR does not fix #25 or #11.

@codecov-io
Copy link

codecov-io commented Oct 29, 2020

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   95.38%   95.38%           
=======================================
  Files           8        8           
  Lines         195      195           
  Branches       19       19           
=======================================
  Hits          186      186           
  Misses          2        2           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af54231...d97c849. Read the comment docs.

@David-Desmaisons David-Desmaisons merged commit b11d685 into David-Desmaisons:master Nov 2, 2020
@David-Desmaisons
Copy link
Owner

Added suport for issue #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues using the library in a .NET Standard 2.1 & .NET Core 3.1 project
3 participants